Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated URI::encode #2483

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Remove deprecated URI::encode #2483

merged 2 commits into from
Nov 3, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Nov 3, 2022

Remove URI::encode

URI::encode() is deprecated: https://ruby-doc.org/stdlib-2.4.4/libdoc/uri/rdoc/URI/Escape.html#method-i-escape-label-Description

URI::encode_www_form_component

Replace with suppored encode_www_form_component function.

https://ruby-doc.org/stdlib-2.4.4/libdoc/uri/rdoc/URI.html#method-c-encode_www_form_component

Closes #2321

@mrharpo mrharpo requested a review from afred November 3, 2022 17:58
@mrharpo mrharpo self-assigned this Nov 3, 2022
afred
afred approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 i added commit that comments out the problematic GeoIP spec that keeps failing.

@afred afred merged commit 00ce255 into master Nov 3, 2022
@afred afred deleted the MLAAAPB-42-uri-encode branch November 3, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Episode search from Record page not working in certain situations
2 participants
@mrharpo @afred