Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor search query with quotes #2491

Merged
merged 24 commits into from
Dec 1, 2022
Merged

Refactor search query with quotes #2491

merged 24 commits into from
Dec 1, 2022

Commits on Nov 15, 2022

  1. Simplify stopwords file ingest

    @mrharpo
    mrharpo committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    60b1aaa View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Refactor query_to_terms_array to helper functions

    @mrharpo
    mrharpo committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    529e5bc View commit details
    Browse the repository at this point in the history

  2. Only grab quotes if there are an even number of double quotes

    @mrharpo
    mrharpo committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    373f400 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Strip punctuation and split quoted terms

    @mrharpo
    mrharpo committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    197d73e View commit details
    Browse the repository at this point in the history

  2. Unquoted terms each in own array

    @mrharpo
    mrharpo committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    79d4f75 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Format with rufo

    @mrharpo
    mrharpo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3db8da5 View commit details
    Browse the repository at this point in the history

  2. Rename get_stopwords -> stopwords

    @mrharpo
    mrharpo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    edf4d0c View commit details
    Browse the repository at this point in the history

  3. MIgrate to lib/query_to_terms_array.rb

    @mrharpo
    mrharpo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8b60d76 View commit details
    Browse the repository at this point in the history

  4. Remove stopwords before nesting arrays

    @mrharpo
    mrharpo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    94e9139 View commit details
    Browse the repository at this point in the history

  5. Fix spec to use new QueryToTermsArray

    @mrharpo
    mrharpo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    9451dee View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Fix formatting with rubocop

    @mrharpo
    mrharpo committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    45b1cef View commit details
    Browse the repository at this point in the history

  2. Add more tests to confirm behavior is as expected

    @mrharpo
    mrharpo committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    30d5daa View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Better handling of edge cases

    @mrharpo
    mrharpo committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    1561c40 View commit details
    Browse the repository at this point in the history

  2. Add additional tests for double quotes

    @mrharpo
    mrharpo committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    3d8c149 View commit details
    Browse the repository at this point in the history

  3. Add inline documentation

    @mrharpo
    mrharpo committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    74953e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Simplify ruby notation

    @mrharpo
    mrharpo committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b91794a View commit details
    Browse the repository at this point in the history

  2. Fix extra space to make rubocop happy

    @mrharpo
    mrharpo committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    cd5dc37 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Adds spec for QueryToTermsArray 

    Adds specs and does a little refactoring of constructor and other methods to
(hopefully) make the logic a little more clear and maintainable.
    @afred
    afred committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    3460f02 View commit details
    Browse the repository at this point in the history

  2. Adds inline docs

    @afred
    afred committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    95efd5f View commit details
    Browse the repository at this point in the history

  3. Remove ArgumentError on empty query, fix tests

    @mrharpo
    mrharpo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    8ad595b View commit details
    Browse the repository at this point in the history

  4. Fix %W() -> %w() to please rubocop

    @mrharpo
    mrharpo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    0e1c556 View commit details
    Browse the repository at this point in the history

  5. Appease rubocop by fixing missing space

    @mrharpo
    mrharpo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    86f3260 View commit details
    Browse the repository at this point in the history

  6. rubocop

    @afred
    afred committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    3307f29 View commit details
    Browse the repository at this point in the history

  7. Migrate [:alpha:] -> [:alnum:], add test

    @mrharpo
    mrharpo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    ec50136 View commit details
    Browse the repository at this point in the history