Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Split CI tests into specs and formatter #2512

Merged
merged 8 commits into from
Dec 21, 2022
Merged

🧪 Split CI tests into specs and formatter #2512

merged 8 commits into from
Dec 21, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Dec 12, 2022

🧪 CI tests

Split tests into separate jobs with github's reusable workflows https://docs.github.com/en/actions/using-workflows/reusing-workflows

  • 📋 Specs
    • rspec
  • 👮‍♂️ Formatter
    • rubocop

This runs the tests in parallel, instead of in series. Good because:

  • The test suite finishes faster
  • Both tests always run, even if one fails
    • Previously, rubocop errors were hidden behind specs failures
    • This is one of the most frustrating parts about the rubocop experience in the development cycle
  • MUCH easier to see which test is failing without clicking through and reading logs!

Screen Shot 2022-12-12 at 10 24 48

@mrharpo mrharpo added the feature request 🧚 New feature request label Dec 12, 2022
@mrharpo mrharpo self-assigned this Dec 12, 2022
@mrharpo mrharpo merged commit bbe2ce2 into master Dec 21, 2022
@mrharpo mrharpo deleted the split-rubocop branch December 21, 2022 21:11
mrharpo added a commit that referenced this pull request Dec 28, 2022
* master:
  Update 6-identity-and-culture.md (#2494)
  Use prettier 404 page for missing catalog pages (#2501)
  Exclude Notes Pages From 'Records in Exhibit' (#2519)
  'add hms times to clip message on share a segment' (#2509)
  🧪 Split CI tests into specs and formatter (#2512)
  ✖️ Remove AMS dependant specs (#2520)
  Cleaner Embed Iframe (#2481)
  'add rows option for snippet solr search' (#2514)
  Fix template names to display titles correct (#2513)
  Fix syntax for new issue templates (#2511)
  Use new Issue template forms (#2510)
  Primary source tweaks (#2507)
  'fix css for featured banner using spritesheet' (#2504)
  'replace busing guid with correct record in prim sets' (#2503)
  Redirects /educator_resources to /primary_source_sets (#2502)
  Remove target for primary source carousel links (#2500)
  Fixes links to primary source sets in homepage carousel (#2499)
  Primary source links (#2498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🧚 New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants