Adds endpoints for viewing some logs. #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afred
force-pushed
the
log_routes
branch
2 times, most recently
from
3001c29
to
c90114d
Compare
afred
force-pushed
the
log_routes
branch
3 times, most recently
from
31a3e2f
to
5564371
Compare
* Adds route /logs for seeing a list of links to available logs. * Adds route /logs/[:log_file_name] for viewing plain text rendering of an available log file. * To restrict access to some logs, add the filename (or a glob pattern) to LogsController::IGNORE. Attempting to access an ignored log file will respond with a 403 Forbidden. Also: * Comments out problematic spec in spec/scripts/cleaner_spec.rb with sporadically fails for unrelated reasons, likely due to randomness when running the specs, so the spec just needs to be refactored in a major way. But we don't want to keep blocking PRs because of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/logsfor seeing a list of links to available logs./logs/[:log_file_name]for viewing plain text rendering of an available log file.LogsController::IGNORE. Attempting to access an ignored log file will respond with a403 Forbidden.