Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into mentalist_v0.2 #24

Merged
merged 30 commits into from
Mar 24, 2018
Merged

Merge master into mentalist_v0.2 #24

merged 30 commits into from
Mar 24, 2018

Conversation

dfornika
Copy link
Contributor

Prepare for MentaLiST-0.2.2 release.

pedrofeijao and others added 29 commits February 6, 2018 14:01
* Added travis.yml file
…was probably loading it, but for the tests we need this explicitly
* Don't convert fasta_files paths to absolute paths

* Prepend database directory path on to relative paths for allele fasta files in db

* Don't create db_path variable, check for existence of fasta files

* Tidy up newlines

* Added test to check MLST calling after moving a database
@codecov-io
Copy link

codecov-io commented Mar 24, 2018

Codecov Report

Merging #24 into mentalist_v0.2 will increase coverage by 42.91%.
The diff coverage is 1.86%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           mentalist_v0.2      #24       +/-   ##
===================================================
+ Coverage           12.46%   55.38%   +42.91%     
===================================================
  Files                   5        5               
  Lines                 810      836       +26     
===================================================
+ Hits                  101      463      +362     
+ Misses                709      373      -336
Impacted Files Coverage Δ
src/build_db_functions.jl 86.95% <ø> (+63.76%) ⬆️
src/MentaLiST.jl 0% <0%> (ø) ⬆️
src/calling_functions.jl 60.96% <2.04%> (+60.96%) ⬆️
src/mlst_download_functions.jl 61.76% <7.69%> (+0.89%) ⬆️
src/db_graph.jl 94.82% <0%> (+93.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a350d...26300a8. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 55

  • 3 of 161 (1.86%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+42.9%) to 55.383%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mlst_download_functions.jl 1 13 7.69%
src/MentaLiST.jl 0 50 0.0%
src/calling_functions.jl 2 98 2.04%
Files with Coverage Reduction New Missed Lines %
src/mlst_download_functions.jl 1 61.76%
src/MentaLiST.jl 8 0.0%
Totals Coverage Status
Change from base Build 33: 42.9%
Covered Lines: 463
Relevant Lines: 836

💛 - Coveralls

@dfornika dfornika merged commit 4a455bb into mentalist_v0.2 Mar 24, 2018
@cchauve cchauve mentioned this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants