Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more control parameters for implicit Euler, plothistory #87

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

j-fu
Copy link
Member

@j-fu j-fu commented Nov 29, 2023

No description provided.

j-fu added 2 commits November 28, 2023 13:46
* Add Δu_max_factor and Δt_decrease to Solvercontrol.
  Formerly (with values 2.0 and 0.5, respectively) the were fixed.
  New Δu_max_factor=1.2
* Add history to TransientSolution, thus preparing deprecation of system.history
Improve error messaging for time loop
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (80f2d0f) 86.31% compared to head (07fb69f) 85.55%.

Files Patch % Lines
src/gridvisualize.jl 0.00% 17 Missing ⚠️
src/vfvm_exceptions.jl 0.00% 10 Missing ⚠️
src/vfvm_solver.jl 60.00% 4 Missing ⚠️
src/vfvm_transientsolution.jl 25.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   86.31%   85.55%   -0.77%     
==========================================
  Files          24       24              
  Lines        2681     2706      +25     
==========================================
+ Hits         2314     2315       +1     
- Misses        367      391      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu j-fu merged commit e495ccf into master Nov 29, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants