Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bikeshed complain less #162

Open
miketaylr opened this issue Oct 18, 2021 · 5 comments
Open

Make bikeshed complain less #162

miketaylr opened this issue Oct 18, 2021 · 5 comments

Comments

@miketaylr
Copy link
Contributor

miketaylr commented Oct 18, 2021 •
edited
Loading

It seems there's a lot of busted links. I'll fix... some of them.
@miketaylr
Copy link
Contributor Author

whatwg/fetch@efde35d is responsible for LINE ~297: No 'dfn' refs found for 'transmitted bytes'.

whatwg/fetch@7e5c922 is responsible for LINE ~296: No 'dfn' refs found for 'process request body'.

@miketaylr
Copy link
Contributor Author

miketaylr commented Oct 18, 2021 •
edited
Loading

whatwg/fetch@12dd6fa#diff-b4827ee42aceaf9dc3e7216f72262d81c32217e9996fb70a657f259e3ac92604L168 created LINK ERROR: No 'dfn' refs found for 'process response' that are marked for export.

@miketaylr
Copy link
Contributor Author

I'm not really sure what caused LINE ~701: No 'dfn' refs found for 'wait' that are marked for export.. I ran out of energy. :(

miketaylr added a commit to miketaylr/background-fetch that referenced this issue Oct 18, 2021
@miketaylr
Fix a big pile of linking errors.
6aa42be 
Though not all. See WICG#162 for the remaining ones.
miketaylr added a commit to miketaylr/background-fetch that referenced this issue Oct 18, 2021
@miketaylr
Fix a big pile of linking errors.
09e8c80 
Though not all. See WICG#162 for the remaining ones.
@miketaylr miketaylr mentioned this issue Oct 18, 2021
Merged
@miketaylr
Copy link
Contributor Author

Whenever whatwg/xhr#333 lands/settles, 'process request body' can be fixed (probably?)

@annevk
Copy link

annevk commented Oct 19, 2021

Note that for "process request body" while you can fix the xref issue, a more substantial rewrite is needed to align with the new fetch calling conventions.

I recently wrote https://fetch.spec.whatwg.org/#fetch-elsewhere to elaborate a bit on that, though it could be more useful still as that doesn't have examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @annevk