Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify consumption of user activation at the initiation step #20

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

mustaqahmed
Copy link
Collaborator

Closes #13.

@mustaqahmed
Copy link
Collaborator Author

@annevk PTAL if this provides enough clarification.

Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that makes sense, but shouldn't it also be consumed in the document that is activated and wants to delegate?

spec.bs Show resolved Hide resolved
@mustaqahmed
Copy link
Collaborator Author

I guess that makes sense, but shouldn't it also be consumed in the document that is activated and wants to delegate?

Hah, finally seeing your main concern! I agree: starting the consumption at the sender's Window makes the most sense here (even though user activation consumption "resets" the whole frame-tree, so consuming anywhere in the tree should be equivalent).

Wondering what's the right way to specify the sender's Window in this algorithm. Is this "relevant global object of current Window"?

@annevk
Copy link
Contributor

annevk commented Jan 12, 2022

I think you want incumbentSettings's global object for this particular algorithm. This is one of the few if not only case where we want to use the incumbent global.

@mustaqahmed
Copy link
Collaborator Author

I think you want incumbentSettings's global object for this particular algorithm. This is one of the few if not only case where we want to use the incumbent global.

Done.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@mustaqahmed
Copy link
Collaborator Author

@annevk PTAL, finally got a chance to incorporate your suggestions. Sorry for the delay!

@mustaqahmed
Copy link
Collaborator Author

mustaqahmed commented Mar 14, 2022

As we promised in Chrome's intent to ship thread, we are planning to send out a PR to HTML. I think it makes sense if we merge this PR now and start a review on the HTML side for the whole "algorithm".

@annevk
Copy link
Contributor

annevk commented Mar 15, 2022

I wish some more work was done on flushing out #9 and #10 (see also w3ctag/design-reviews#655 (comment)). #15 doesn't seem touched at all.

I suppose we can work on HTML integration, but it's not totally clear we have a shared understanding of how this would all work.

@mustaqahmed
Copy link
Collaborator Author

I wish some more work was done on flushing out #9 and #10 (see also w3ctag/design-reviews#655 (comment)). #15 doesn't seem touched at all.

I suppose we can work on HTML integration, but it's not totally clear we have a shared understanding of how this would all work.

That's fair, thanks. Deferring the HTML integration plan until we have addressed them.

As for this PR, do you think it needs more work to close #13?

Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks okay. Thanks!

@mustaqahmed mustaqahmed merged commit 4641cda into main Mar 15, 2022
@mustaqahmed mustaqahmed deleted the clarify-consumption branch April 20, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why consumption of user gesture in targetWindow
2 participants