Refactor constructor and replaceSync() steps so CSS modules can reference them #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steps to create a CSS module (spec draft) should reference the steps in this spec to create a constructable stylesheet and run
replaceText(). This will help ensure that the behavior of CSS modules and constructable stylesheets remains consistent as much as possible.To make this possible, this change refactors the implementations of these algorithms into separate sets of steps that CSS modules can reference directly. By referencing these new algorithms instead of the public methods, this makes it clear that the behavior of CSS modules shouldn't change if the public methods for
CSSStyleSheetare replaced by script.Preview | Diff