Improve Controlled Frame spec and introduce monkey patching concepts #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

robbiemc merged 17 commits into main from spec-base

Jan 30, 2025

Collaborator

chasephillips commented Jan 29, 2025 •

edited by pr-preview bot

Loading

Chase Phillips added 9 commits

January 28, 2025 17:40


          spec: Add a controlledframe element header

bafc41e


          spec: Add section referring to the fenced frame spec

5cd15aa


          spec: Add initial text describing controlledframe element

7d2d9d8


          spec: add element definition list, move IDL to near top of spec

2bf94f8


          spec: remove unused allow attribute, fix repo/URL/ED attrs

ab22b48


          spec: make monkey patching expectation explicit in the specification …

423a63e

…document


          spec: Move API sections above usage/use cases/security sections

2cde342


          spec: Remove Concepts section

43ad6fb


          spec: Remove API header so subsections merge with the top CF element

715c79d

chasephillips requested a review from robbiemc

January 29, 2025 22:34

robbiemc reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

robbiemc reviewed

View reviewed changes

Collaborator

robbiemc left a comment

Thanks! I left a few comments.

Chase Phillips added 7 commits

January 29, 2025 19:49


          spec: add monkey patching sections

44ef171


          spec: respond to robbiemc@'s feedback

45ae713

- adjust top-level traversible comment to refer to nested top-levels


          spec: robbiemc@ feedback: replace SecureContext with IsolatedContext


          spec: robbiemc@ feedback: refer to policy-controlled feature

a664479


          spec: robbiemc@ feedback: include update spec availability text

78d38e8


          spec: robbiemc@ feedback: update cross-origin security concerns


          spec: robbiemc@ feedback: rewrite "storage user agent" in spec terms

d06ae00

chasephillips commented

View reviewed changes

index.bs Show resolved Hide resolved


          spec: fix build

8f90ff0

robbiemc approved these changes

View reviewed changes

robbiemc merged commit ed6b6f2 into main

2 checks passed

robbiemc deleted the spec-base branch

January 30, 2025 19:14

github-actions bot added a commit that referenced this pull request


          Improve Controlled Frame spec and introduce monkey patching concepts (#…

ce4dc65

…59)

SHA: ed6b6f2
Reason: push, by robbiemc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot added a commit to robbiemc/controlled-frame that referenced this pull request


          Improve Controlled Frame spec and introduce monkey patching concepts (W…

9f23f87

…ICG#59)

SHA: ed6b6f2
Reason: push, by robbiemc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet