Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop navigator.identity namespace #164

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Drop navigator.identity namespace #164

merged 1 commit into from
Sep 16, 2024

Conversation

marcoscaceres
Copy link
Collaborator

@marcoscaceres marcoscaceres commented Sep 4, 2024 •
edited
Loading

Closes #???

The following tasks have been completed:

Implementation commitment:

Documentation and checks

  • Affects privacy
  • Affects security
  • Pinged MDN
  • Updated Explainer

Preview | Diff

samuelgoto
samuelgoto approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoscaceres
Copy link
Collaborator Author

Filed https://bugs.webkit.org/show_bug.cgi?id=279159 for WebKit... I'll update the tests etc.

bvandersloot-mozilla
bvandersloot-mozilla approved these changes Sep 5, 2024
View reviewed changes
Copy link

@bvandersloot-mozilla bvandersloot-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes to CredMan disallowing digital being mixed with other credential types, this is okay.

@samuelgoto
Copy link
Collaborator

Filed https://bugs.webkit.org/show_bug.cgi?id=279159 for WebKit... I'll update the tests etc.

Added chromium implementation bug too.

@samuelgoto samuelgoto mentioned this pull request Sep 10, 2024
Merged
@marcoscaceres marcoscaceres mentioned this pull request Sep 12, 2024
Merged
@marcoscaceres
Copy link
Collaborator Author

Updates to the test suite:
web-platform-tests/wpt#48117

I need to check these are correct against an engine still, but it's a start. We need to check for redundant tests.

@marcoscaceres marcoscaceres merged commit b6c64a1 into main Sep 16, 2024
1 check passed
@samuelgoto
Copy link
Collaborator

Added chromium implementation bug too.

FWIW, this is already implemented in Chrome Canaries as of last week:

https://g-issues.chromium.org/issues/364957810?pli=1&authuser=0

@samuelgoto samuelgoto mentioned this pull request Sep 16, 2024
Open
@marcoscaceres marcoscaceres deleted the remove_identity branch September 16, 2024 21:44
@marcoscaceres
Copy link
Collaborator Author

Great, will try to get WebKit updated soon!

marcoscaceres added a commit to marcoscaceres/WebKit that referenced this pull request Jan 11, 2025
@marcoscaceres
Digital Credentials: drop navigator.identity, use navigator.crendenti…
7011100 
…als instead

https://bugs.webkit.org/show_bug.cgi?id=279159
rdar://135835222

Reviewed by NOBODY (OOPS!).

Drop the navigator.identity namespace, and do everything through navigator.credentials instead.

Spec change:
WICG/digital-credentials#164

Web platform Tests Upstream commit:
web-platform-tests/wpt@fd7b0de

* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html:
* LayoutTests/http/wpt/identity/idl.https-expected.txt:
* LayoutTests/http/wpt/identity/idl.https.html:
* LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.js: Added.
(test):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(export.makeGetOptions):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/iframe.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/permissions-policy/resources/digital-credentials-get.html:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h:
* Source/WebCore/Modules/identity/Navigator+Identity.idl: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.cpp: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.h: Removed.
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
@marcoscaceres marcoscaceres mentioned this pull request Jan 11, 2025
Open
marcoscaceres added a commit to marcoscaceres/WebKit that referenced this pull request Jan 11, 2025
@marcoscaceres
Digital Credentials: drop navigator.identity, use navigator.crendenti…
eed9de1 
…als instead

https://bugs.webkit.org/show_bug.cgi?id=279159
rdar://135835222

Reviewed by NOBODY (OOPS!).

Drop the navigator.identity namespace, and do everything through navigator.credentials instead.

Spec change:
WICG/digital-credentials#164

Web platform Tests Upstream commit:
web-platform-tests/wpt@fd7b0de

* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html:
* LayoutTests/http/wpt/identity/idl.https-expected.txt:
* LayoutTests/http/wpt/identity/idl.https.html:
* LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.js: Added.
(test):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(export.makeGetOptions):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/iframe.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/permissions-policy/resources/digital-credentials-get.html:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h:
* Source/WebCore/Modules/identity/Navigator+Identity.idl: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.cpp: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.h: Removed.
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
marcoscaceres added a commit to marcoscaceres/WebKit that referenced this pull request Jan 13, 2025
@marcoscaceres
Digital Credentials: drop navigator.identity, use navigator.crendenti…
3e99e82 
…als instead

https://bugs.webkit.org/show_bug.cgi?id=279159
rdar://135835222

Reviewed by NOBODY (OOPS!).

Drop the navigator.identity namespace, and do everything through navigator.credentials instead.

Spec change:
WICG/digital-credentials#164

Web platform Tests Upstream commit:
web-platform-tests/wpt@fd7b0de

* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html:
* LayoutTests/http/wpt/identity/idl.https-expected.txt:
* LayoutTests/http/wpt/identity/idl.https.html:
* LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.js: Added.
(test):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(export.makeGetOptions):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/iframe.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/permissions-policy/resources/digital-credentials-get.html:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h:
* Source/WebCore/Modules/identity/Navigator+Identity.idl: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.cpp: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.h: Removed.
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
marcoscaceres added a commit to marcoscaceres/WebKit that referenced this pull request Jan 13, 2025
@marcoscaceres
Digital Credentials: drop navigator.identity, use navigator.crendenti…
67391a8 
…als instead

https://bugs.webkit.org/show_bug.cgi?id=279159
rdar://135835222

Reviewed by NOBODY (OOPS!).

Drop the navigator.identity namespace, and do everything through navigator.credentials instead.

Spec change:
WICG/digital-credentials#164

Web platform Tests Upstream commit:
web-platform-tests/wpt@fd7b0de

* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-basics.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-get-hidden.https.html:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt:
* LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html: Removed.
* LayoutTests/http/wpt/identity/idl.https-expected.txt:
* LayoutTests/http/wpt/identity/idl.https.html:
* LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html:
* LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/allow-attribute.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/disabled-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get-user-activation.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-get.tentative.https.html.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.js: Added.
(test):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/historical.any.worker.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/identity-create.tentative.https-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(export.makeGetOptions):
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/iframe.html:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/permissions-policy/resources/digital-credentials-get.html:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h:
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp:
(WebCore::CredentialRequestCoordinator::discoverFromExternalSource):
* Source/WebCore/Modules/identity/Navigator+Identity.idl: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.cpp: Removed.
* Source/WebCore/Modules/identity/NavigatorIdentity.h: Removed.
* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvandersloot-mozilla bvandersloot-mozilla bvandersloot-mozilla approved these changes

@timcappalli timcappalli timcappalli approved these changes

@samuelgoto samuelgoto samuelgoto approved these changes

@RByers RByers Awaiting requested review from RByers RByers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoscaceres @samuelgoto @timcappalli @bvandersloot-mozilla