Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial intro text #193

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add initial intro text #193

wants to merge 4 commits into from

Conversation

timcappalli
Copy link
Member

@timcappalli timcappalli commented Dec 11, 2024

Closes #182

Very basic intro text for CGR1


Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial fixes (grammar, punctuation, etc.)

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
<p id="credential-type-examples">
There are many types of digital credential that can be presented using
There are many types of verifiable digital credentials that can be presented using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are many types of verifiable digital credentials that can be presented using
There are many types of verifiable digital credential that can be presented using

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallTed can you explain this one? Singular sounds very weird when read aloud. If I were to replace VDCs with "documents", just to try a different word, I don't think "document" would be correct ("...there are many types of document that can be presented using...")

Copy link
Contributor

@TallTed TallTed Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay.

"...there are many types of document that can be presented using..." would be correct.

"...there are many types of documents that can be presented using..." would not.

Try changing types to kinds and document to pizza. I expect "There are many kinds of pizzas that you can order" and "You can order many kinds of pizzas" will both sound odd to you. I expect "There are many kinds of pizza that you can order" and "You can order many kinds of pizza" will both sound right.

If you really want the plural credentials, I might suggest

Suggested change
There are many types of verifiable digital credentials that can be presented using
Verifiable digital credentials of many types can be presented using

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spec] Add initial intro text
4 participants