Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Proposal: sync-script #2

Open
natechapin opened this issue Feb 5, 2018 · 5 comments
Open

Feature Proposal: sync-script #2

natechapin opened this issue Feb 5, 2018 · 5 comments

Comments

@natechapin
Copy link

Parser-blocking script can greatly delay the appearance of meaningful content. The proposal is to add a new feature, sync-script, which is enabled by default (default allowlist is *).

When disabled, a script that would block parsing until its completion would not be run. The decision on whether a script will block parsing is made in step 24 of preparing a script in the HTML spec. This feature, when disabled, would prevent execution for the second and fifth clauses (where the element becomes the "pending parser-blocking script"), and the sixth clause when the element is flagged as parser-inserted.

This could be specified as a new step somewhere before step 24 (around step 11 perhaps):
If the element's node document is not allowed to use the sync-script feature, and the element does not have a defer attribute, and the element has been flagged as "parser-inserted", and the element does not have an async attribute, then return. The script is not executed.
@hiroshige-g
Copy link

the sixth clause when the element is flagged as parser-inserted

Should we block dynamically-inserted inline scripts?
(I'm neutral about this, just want to clarify)
They aren't parser-blocking but are evaluated synchronously, so might be considered as "sync".

@ojanvafai
Copy link
Member

Do dynamically inserted scripts behave like async exactly?

@hiroshige-g
Copy link

dynamically-inserted inline scripts are executed immediately (unless there are pending style sheets).
However, I noticed when inline scripts are dynamically inserted, the script that inserted them is already being evaluated and thus whether to block dynamically-inserted inline scripts might not be important in terms of design and concept.

dynamically-inserted external scripts behave like async exactly (unless async/defer/etc. are added/modified).

@hiroshige-g
Copy link

(in the case of classic scripts)

chromium-wpt-export-bot referenced this issue in web-platform-tests/wpt Jul 10, 2018
@natechapin
FeaturePolicy sync-script
f5b7b9d 
Spec discussion: https://github.com/WICG/feature-policy/issues/135

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
chromium-wpt-export-bot referenced this issue in web-platform-tests/wpt Jul 11, 2018
@natechapin
FeaturePolicy sync-script
1498e1d 
Spec discussion: https://github.com/WICG/feature-policy/issues/135

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
chromium-wpt-export-bot referenced this issue in web-platform-tests/wpt Jul 11, 2018
@natechapin
Implement FeaturePolicy sync-script (as an experimental feature policy)
79dc5f5 
Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
chromium-wpt-export-bot referenced this issue in web-platform-tests/wpt Jul 19, 2018
@natechapin
Implement FeaturePolicy sync-script (as an experimental feature policy)
a3922f2 
Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576652}
aarongable referenced this issue in chromium/chromium Jul 19, 2018
@natechapin
Implement FeaturePolicy sync-script (as an experimental feature policy)
1f227e0 
Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576652}
chromium-wpt-export-bot referenced this issue in web-platform-tests/wpt Jul 20, 2018
@natechapin @chromium-wpt-export-bot
Implement FeaturePolicy sync-script (as an experimental feature policy)
0cc3831 
Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576652}
moz-v2v-gh referenced this issue in mozilla/gecko-dev Jul 29, 2018
@natechapin @jgraham
Bug 1459006 [wpt PR 10827] - Implement FeaturePolicy sync-script (as …
4e2376c 
…an experimental feature policy), a=testonly

Automatic update from web-platform-testsImplement FeaturePolicy sync-script (as an experimental feature policy)

Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576652}

--

wpt-commits: 0cc3831f4c19152ec28b4a1fa600baace321c775
wpt-pr: 10827
jankeromnes referenced this issue in jankeromnes/gecko Jul 30, 2018
@natechapin @jgraham
Bug 1459006 [wpt PR 10827] - Implement FeaturePolicy sync-script (as …
59a76b7 
…an experimental feature policy), a=testonly

Automatic update from web-platform-testsImplement FeaturePolicy sync-script (as an experimental feature policy)

Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576652}

--

wpt-commits: 0cc3831f4c19152ec28b4a1fa600baace321c775
wpt-pr: 10827
@ryantownsend
Copy link

Would love to see this added as a mechanism to ban blocking script downloads. This way it's a mechanism to enforce a web performance budget in terms of 'zero synchronous script downloads'.

If this could be extended to stylesheets too, that would be even better. A feature policy like:

Feature-Policy: sync-stylesheet 'self'; sync-script 'none'

would mean we allow our own 1st party stylesheet(s), but prevent people putting SPOFs like Google Font stylesheet <link> tags into the <head>, but nobody 1st or 3rd party can use blocking synchronous scripts.

gecko-dev-updater referenced this issue in marco-c/gecko-dev-wordified-and-comments-removed Oct 3, 2019
@marco-c
Bug 1459006 [wpt PR 10827] - Implement FeaturePolicy sync-script (as …
3798feb 
…an experimental feature policy), a=testonly

Automatic update from web-platform-testsImplement FeaturePolicy sync-script (as an experimental feature policy)

Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojanchromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Nate Chapin <japhetchromium.org>
Cr-Commit-Position: refs/heads/master{#576652}

--

wpt-commits: 0cc3831f4c19152ec28b4a1fa600baace321c775
wpt-pr: 10827

UltraBlame original commit: a1f1e78ef7757951af1102a8d93d649812c9c8ae
gecko-dev-updater referenced this issue in marco-c/gecko-dev-comments-removed Oct 3, 2019
@marco-c
Bug 1459006 [wpt PR 10827] - Implement FeaturePolicy sync-script (as …
8a2773e 
…an experimental feature policy), a=testonly

Automatic update from web-platform-testsImplement FeaturePolicy sync-script (as an experimental feature policy)

Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojanchromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Nate Chapin <japhetchromium.org>
Cr-Commit-Position: refs/heads/master{#576652}

--

wpt-commits: 0cc3831f4c19152ec28b4a1fa600baace321c775
wpt-pr: 10827

UltraBlame original commit: a1f1e78ef7757951af1102a8d93d649812c9c8ae
gecko-dev-updater referenced this issue in marco-c/gecko-dev-wordified Oct 3, 2019
@marco-c
Bug 1459006 [wpt PR 10827] - Implement FeaturePolicy sync-script (as …
60e2f0c 
…an experimental feature policy), a=testonly

Automatic update from web-platform-testsImplement FeaturePolicy sync-script (as an experimental feature policy)

Spec discussion: https://github.com/WICG/feature-policy/issues/135
Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/b7f_K30MBYo

Bug: 862422
Change-Id: Icd8a5d747373a819c7073ac459b5e8823d7986a8
Reviewed-on: https://chromium-review.googlesource.com/894137
Reviewed-by: Ojan Vafai <ojanchromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Nate Chapin <japhetchromium.org>
Cr-Commit-Position: refs/heads/master{#576652}

--

wpt-commits: 0cc3831f4c19152ec28b4a1fa600baace321c775
wpt-pr: 10827

UltraBlame original commit: a1f1e78ef7757951af1102a8d93d649812c9c8ae
@clelland clelland transferred this issue from w3c/webappsec-permissions-policy Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryantownsend @ojanvafai @hiroshige-g @natechapin