Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Garrett Tanzer committed Sep 6, 2023
1 parent 402c969 commit d65df98
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ following [=struct/items=]:
:: a [=fencedframetype/fenced frame reporting map=]

: <dfn>direct seller is seller</dfn>
:: a [=boolean=]
:: a [=boolean=], initially true

: <dfn>allowed reporting origins</dfn>
:: null or a [=list=] of [=origins=]
Expand Down Expand Up @@ -802,7 +802,8 @@ A <dfn export for=fencedframetype>destination event</dfn> is either a
1. Let |macro map| be |destination info|'s [=reporting destination info/reporting macro map=].
1. If |macro map| is null, return.
1. Set |destination url| to |event|.
1. TODO: Substitute macros from |macro map| into |destination url|.
1. Let |destination url| be the result of [=fencedframeutil/substituting macros=] with
|macro map| into |destination url|.

1. Let |request| be a new [=request=] with the following properties:

Expand Down Expand Up @@ -1267,17 +1268,18 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.
};

dictionary FenceEvent {
// This dictionary has two mutually exclusive modes:
// This dictionary has two mutually exclusive modes that aren't represented as
// distinct IDL types due to distinguishability issues:
//
// When reporting to a preregistered destination (specified by enum), the following properties
// are used:
// When reporting to a preregistered destination (specified by enum), the following
// properties are used:
DOMString eventType;
DOMString eventData;
sequence&lt;FenceReportingDestination&gt; destination;
boolean once = false;

// When reporting to a custom destination URL (with substitution of macros defined by the
// Protected Audience buyer), the following property is used:
// When reporting to a custom destination URL (with substitution of macros defined by
// the Protected Audience buyer), the following property is used:
USVString destinationURL;
};

Expand Down

0 comments on commit d65df98

Please sign in to comment.