Add RTCPeerConnection constructor error to spec. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because WebRTC's RTCPeerConnection interface is disallowed in fenced frames, we need to patch the WebRTC spec to throw an exception in the constructor. This patch also introduces the a "fenced navigable ancestor" algorithm that can be used to determine if a given document is nested in a fenced frame tree. This mechanism is used to trigger the constructor error.
blu25
previously requested changes
Nov 8, 2024
blu25
approved these changes
Nov 8, 2024
VergeA
dismissed
blu25’s stale review
I made the changes requested in a separate commit, so I am making this prompt go away :)
github-actions bot
added a commit
that referenced
this pull request
Nov 8, 2024
SHA: a22434f Reason: push, by VergeA Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Sorry, just realized I should have requested @domfarolino's review first (my brain saw the merge button and went on autopilot). I can revert this if necessary, or we can sync up later to address comments in a follow-up. |
domfarolino
reviewed
Nov 8, 2024
VergeA
added a commit
to VergeA/fenced-frame
that referenced
this pull request
Nov 11, 2024
PR WICG#197 was merged prematurely, so these changes should cover the remaining two comments.
domfarolino
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because WebRTC's RTCPeerConnection interface is disallowed in fenced frames, we need to patch the WebRTC spec to throw an exception in the constructor.
Preview | Diff