Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Access dictionaries as maps #419

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

a-sully
Copy link
Collaborator

@a-sully a-sully commented Jun 20, 2023

Follow-up to whatwg/fs#90

Also fixes a use of FileSystemPermissionDescriptor in the showDirectoryPicker() method algorithm


Preview | Diff

@a-sully
Copy link
Collaborator Author

a-sully commented Jun 20, 2023

no rush @inexorabletash but PTAL when you get a chance :)

index.bs Show resolved Hide resolved
Follow-up to whatwg/fs#90

Also fixes a use of FileSystemPermissionDescriptor in
the showDirectoryPicker() method algorithm
Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor things.

FYI the changes in word wrapping make the diffs hard to read. Consider not wrapping the source text.

index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@a-sully
Copy link
Collaborator Author

a-sully commented Jun 22, 2023

LGTM with some minor things.

Thanks for the review!

FYI the changes in word wrapping make the diffs hard to read. Consider not wrapping the source text.

Ack

@a-sully a-sully merged commit 739b0c4 into WICG:main Jun 22, 2023
@a-sully a-sully deleted the fix-dot-access branch June 22, 2023 20:45
github-actions bot added a commit that referenced this pull request Jun 22, 2023
Follow-up to whatwg/fs#90

Also fixes a use of FileSystemPermissionDescriptor in
the showDirectoryPicker() method algorithm

SHA: 739b0c4
Reason: push, by @a-sully

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants