Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: spec: update in parallel steps to resolve or reject in tasks #36

Merged
merged 5 commits into from
Nov 8, 2024
Merged

WIP: spec: update in parallel steps to resolve or reject in tasks #36

merged 5 commits into from
Nov 8, 2024

Conversation

wacky6
Copy link
Member

@wacky6 wacky6 commented Sep 20, 2024 •
edited by pr-preview bot
Loading

@wacky6 wacky6 force-pushed the wip-in-parallel-steps branch from d76ae42 to e31a0e9 Compare September 20, 2024 04:28
@wacky6 wacky6 requested a review from tidoust September 24, 2024 08:24
@wacky6
Copy link
Member Author

wacky6 commented Sep 24, 2024

tidoust: Can you review this?

If it looks good, i'll update other algorithms in a similar way.

tidoust
tidoust reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. See inline for suggestions for improvement.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
wacky6 and others added 2 commits November 7, 2024 13:55
@wacky6 @tidoust
Apply suggestions from code review
10fcdc2 
Co-authored-by: François Daoust <fd@tidoust.net>
@wacky6
fix references
d140c86
@wacky6 wacky6 force-pushed the wip-in-parallel-steps branch from 99c5e70 to d140c86 Compare November 7, 2024 03:29
@wacky6
Copy link
Member Author

wacky6 commented Nov 7, 2024

@tidoust can you do another pass?

tidoust
tidoust approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Looks goot to me otherwise!

spec.bs Outdated Show resolved Hide resolved
@wacky6 @tidoust
Update spec.bs
cac60eb 
Co-authored-by: François Daoust <fd@tidoust.net>
@wacky6 wacky6 marked this pull request as ready for review November 8, 2024 01:04
@wacky6 wacky6 merged commit 1588579 into main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tidoust tidoust tidoust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wacky6 @tidoust