Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed semantics/tests to write:
abort
. This is true even if you're in the middle of anavigate
event handler (perhaps one of many event handlers); it doesn't wait until the end.window.stop()
will synchronously cause the signal to fireabort
.abort
, since that cancels ongoing navigations.abort
happens synchronously and immediately, but other consequences such asnavigateerror
happen asynchronously at the bottom of the "innernavigate
event firing algorithm"navigate
event handler will cause the signal to fireabort
event.preventDefault()
in anynavigate
event handler will cause the signal to fireabort
abort
fires after all event handlers have run (not immediately upon the action), but synchronously. Then, after a microtask,navigateerror
fires onappHistory
.document.open()
cancels navigations and should have a similar impact towindow.stop()
, synchronously. Although Clarify how to cancel a navigation whatwg/html#3447 makes me a bit suspicious.Preview | Diff