Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observable unsubscription timing #120

Merged
merged 1 commit into from
Feb 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,13 @@ The <dfn attribute for=Subscriber><code>signal</code></dfn> getter steps are to

1. [=close a subscription|Close=] [=this=].

1. [=AbortController/Signal abort=] [=this=]'s [=Subscriber/complete or error controller=].

1. If |error algorithm| is not null, then run |error algorithm| given |error|.

[=Assert=]: No <a spec=webidl lt="an exception was thrown">exception was thrown</a>.

1. Otherwise (i.e., when |error algorithm| is null), [=report the exception=] |error|.

1. [=AbortController/Signal abort=] [=this=]'s [=Subscriber/complete or error controller=].
</div>

<div algorithm>
Expand All @@ -235,11 +235,11 @@ The <dfn attribute for=Subscriber><code>signal</code></dfn> getter steps are to

1. [=close a subscription|Close=] [=this=].

1. [=AbortController/Signal abort=] [=this=]'s [=Subscriber/complete or error controller=].

1. If |complete algorithm| is not null, then run |complete algorithm|.

[=Assert=]: No <a spec=webidl lt="an exception was thrown">exception was thrown</a>.

1. [=AbortController/Signal abort=] [=this=]'s [=Subscriber/complete or error controller=].
</div>

<div algorithm>
Expand Down
Loading