Observable#last should also reject with RangeError with no last value #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraisr
commented
Oct 21, 2024
| @@ -1243,7 +1243,7 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w | |||
| ignore>value</var>. | |||
|
|
|||
| : [=internal observer/error steps=] | |||
| :: | |||
| :: | |||
There was a problem hiding this comment.
My IDE auto trimmed this whitespace, arguably unrelated to this change — so happy to revert if so.
|
cc @domfarolino |
keithamus
approved these changes
Oct 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 23, 2024
SHA: d576611 Reason: push, by keithamus Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
(Thanks for taking care of this, and thanks @keithamus for getting to it so quickly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the last change in #179, for observable first — we probably want the same to be true for last. There is an inflight wpt update diff for this too: web-platform-tests/wpt#48717
Preview | Diff