Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example in README.md #183

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

flensrocker
Copy link
Contributor

@flensrocker flensrocker commented Nov 12, 2024

In the websocket example the return value of the subscribe calls are stored in variables.

The current spec doesn't implement a "subscription" return value, this might be a left over from the past.

Fixes #184

Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@w3cbot
Copy link

w3cbot commented Nov 18, 2024

domfarolino marked as non substantive for IPR from ash-nazg.

@domfarolino
Copy link
Collaborator

The build is failing for an unrelated reason that I'll figured out separately from this PR, so I'll just land this.

@domfarolino domfarolino merged commit e1d9685 into WICG:master Nov 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in websocket example in README.md
3 participants