Reject reduce#complete with a RangeError in favor of TypeError #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraisr
changed the title
|
cc @domfarolino |
|
Thanks a lot. Honestly I don't feel very strongly here, but I vaguely recall @benlesh being more interested in the decisions around RangeErrors here. Ben, can I ask for your opinion on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Im proposing to merge could swing either way, so opening this more up as a point of discussion and if we agree, lets merge.
For our
firstandlastpromise-returning operators, if there were no values produced by the time thecompletehandlers fire, we reject with aRangeError. But here, withreducethe spec wants aTypeError.Should we keep consistency, and have the spec want a
RangeError? I understand there is an extra clause in that there was no initial value either.Thoughts?
Preview | Diff