Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addTeardown(). Closes #3. Closes #19. #61

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Add addTeardown(). Closes #3. Closes #19. #61

merged 4 commits into from
Sep 13, 2023

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    5ad3128 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Remove old note

    domfarolino committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    69e0c81 View commit details
    Browse the repository at this point in the history
  2. Remove the syntactic sugar analogy

    The intent with that analogy was to describe how *part* of `addTeardown()`
    is syntactic sugar over immediately checking `subscriber.signal.aborted`,
    and *otherwise* setting the given cleanup function to the signal's abort
    handler, and also invoking it during `complete()` and `error()`, but that
    latter part was not clear at all and was contradictory as @annevk pointed
    out. So this commit removes the example, in favor of the earlier descriptive
    text.
    domfarolino committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e8fa9fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    29bb984 View commit details
    Browse the repository at this point in the history