Update examples #83
Open
Update examples #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are conflicts in this PR now because this PR somehow contained all of the "prettier" changes that the PR did. |
|
Ping :) |
…have imperative versions for each example. Adds a new example that creates a measuring tool to measure distance on the page.
benlesh
force-pushed
the
benlesh/update-examples
branch
from
7dea4cc
to
82be7a9
Compare
|
Weird... That diff was gnarly. I just redid the changes on top of master. |
domfarolino
reviewed
Dec 2, 2023
README.md
Outdated
| element.addEventListener( | ||
| 'mousemove', | ||
| (e) => { | ||
| element.addEventListener('mouseup', (e) => controller.abort()); | ||
| element.addEventListener('mouseup', (e) => ac.abort(), { | ||
| signal: controller.signal, |
There was a problem hiding this comment.
This would have to be ac.signal, since controller shouldn't exist. But also, why do we have to pass it in here anyways, if the previous version of this example wasn't?
There was a problem hiding this comment.
Looks like you didn't get to this:
But also, why do we have to pass it in here anyways, if the previous version of this example wasn't?
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
domfarolino
reviewed
Dec 24, 2023
| const { clientX: startX, clientY: startY } = e; | ||
|
|
||
| const svg = document.createElement('svg'); | ||
| svg.width = document.body.width; |
|
@benlesh do you plan on finishing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the examples to reflect recent changes. Also ensures that we have imperative versions for each example.
Adds a new example that creates a measuring tool to measure distance on the page.