[Explainer] Add alternative approach to extend sendBeacon
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This summarize the discussion from WebKit/standards-positions#85 (comment) and also potentially unblocks the need to add custom headers in WICG#50
fergald
reviewed
Mar 9, 2023
| To support the [requirements](#requirements) and to make the new API backward compatible, we propose the following shape: | ||
|
|
||
| ```ts | ||
| navigator.sendBeacon(url, fetchOptions): PendingBeacon |
There was a problem hiding this comment.
I don't think this can work like this. data is the second argument, this would have to be
navigator.sendBeacon(url, data, fetchOptions): PendingBeaconwhich would mean that body below might not be needed and maybe data would be null for a GET or would be the URL.
|
|
||
| The reason why `signal` and `AbortController` is not desired is that the proposal would like to supports more than just aborting the requests, it also needs to check pending states and accumulate data. Supporting these requirements via the returned `PendingBeacon` object allows more flexibility. | ||
|
|
||
| The above API itself is enough for the requirements (2) and (3), but not for (1), which requires delaying the request. As the `sendBeacon` semantic doesn't make sense for the "delaying" behavior, proposing a new function is better: |
There was a problem hiding this comment.
I think it's OK to mention this argument but it's not a technical limitation, we could add an option to the say that when options are present, it doesn't send immediately. I think that's a confusing API but there's no technical reason blocking it (I think).
There was a problem hiding this comment.
I want to make it clear that this is not a good approach. I've added another alternative "Introducing queueBeacon() API" below, which is rather preferred.
mingyc
added a commit
to mingyc/pending-beacon
that referenced
this pull request
Mar 9, 2023
Address comments from WICG#68 Also a follow up to WICG#50 and WebKit/standards-positions#85 (comment)
mingyc
added a commit
that referenced
this pull request
Mar 9, 2023
Address comments from #68 Also a follow up to #50 and WebKit/standards-positions#85 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change summarizes the discussion from
WebKit/standards-positions#85 (comment) and also potentially unblocks the need to add custom headers in #50