Handle Shared-Storage-Write as a single batchUpdate(); Respect withLo… #205

xyaoinum · 2024-10-31T20:09:15Z

…ck for inner methods within batchUpdate()

Two revisions to our initial proposal:

For Shared-Storage-Write, our initial proposal included individual methods like set(), append(), delete(), and clear(), alongside a batchUpdate() method requiring a serialized string for its methods parameter. To make things simpler, we revise the proposal to treat everything as a single batchUpdate(). It's backward compatible.
Our initial proposal ignored the withLock option for individual methods within a batchUpdate() operation. This approach lacked flexibility and could lead to unintended behavior, as developers might assume the lock should still be acquired. We've revised the proposal to respect the withLock option for each individual method within the batch.

…ck for inner methods within batchUpdate() Two revisions to our initial proposal: 1. Our initial proposal included individual methods like set(), append(), delete(), and clear(), alongside a batchUpdate() method requiring a serialized string for its `methods` parameter. To make things simpler, we revise the proposal to treat everything as a single batchUpdate(). 2. Our initial proposal ignored the `withLock` option for individual methods within a batchUpdate() operation. This approach lacked flexibility and could lead to unintended behavior, as developers might assume the lock should still be acquired. We've revised the proposal to respect the `withLock` option for each individual method within the batch.

xyaoinum · 2024-10-31T20:09:47Z

@pythagoraskitty / @jkarlin : PTAL. Thanks!

pythagoraskitty · 2024-11-05T21:14:59Z

Should there be any updates to the examples section for response headers?

Otherwise I think it is looking good % my question above. I will take another pass if you make more changes. :)

xyaoinum · 2024-11-05T22:27:53Z

Should there be any updates to the examples section for response headers?

Updated to using batchUpdate() (although the original example should also be valid, as a batchUpdate() without locks should be equivalent to executing individual methods in sequence). I also included two examples within the From response headers section.

jkarlin

lgtm w/ comment

README.md

…d SharedStorageWorklet Implement the { withLock: <lock resource name> } option for the modifier methods for Window and SharedStorageWorklet context. The SharedStorageLockManager manages the state of the locks and locked requests. It acts as the LockRequest receiver to listen to Granted() calls to resolve those requests. The locks uses the shared storage origin as the partitioning origin, and thus can interact with the regular Web Locks API (i.e. navigator.locks.request()) from within the shared storage worklet. The locking function is gated behind features::kSharedStorageWebLocks, which is checked in the browser process in SharedStorageLockManager::SharedStorageUpdate(). Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: I7003d392076a65a9ff2d277f9f0c2791436d2f68

…d SharedStorageWorklet Implement the { withLock: <lock resource name> } option for the modifier methods for Window and SharedStorageWorklet context. The SharedStorageLockManager manages the state of the locks and locked requests. It acts as the LockRequest receiver to listen to Granted() calls to resolve those requests. The locks uses the shared storage origin as the partitioning origin, and thus can interact with the regular Web Locks API (i.e. navigator.locks.request()) from within the shared storage worklet. The locking function is gated behind features::kSharedStorageWebLocks, which is checked in the browser process in SharedStorageLockManager::SharedStorageUpdate(). Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: I7003d392076a65a9ff2d277f9f0c2791436d2f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020796 Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1387751}

… headers Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 How: - Add the parameter parsing logic in the network service, and send the final request to the browser process's central SharedStorageLockManager component. - Since SharedStorageLockManager::SharedStorageUpdate() hides the exact database result, we update observer's OnMethodFinished()'s parameters accordingly. In the test observer, the error message is further transformed into a boolean 'success' result. This callback is only used in tests and it's not important to assert the detailed result anyway. - A new test, `SharedStorageHeaderObserverTest.Append_NoCapacity`, has been added to demonstrate the case where `SharedStorageUpdate` encounters an error. Bug: 373899210 Change-Id: I4588c83174d465e7248cc1f41c9b7a693aa326f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042601 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388298}

…odifier options for Window and SharedStorageWorklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement 'with_lock' modifier options for Window and SharedStorageWorklet Implement the { withLock: <lock resource name> } option for the modifier methods for Window and SharedStorageWorklet context. The SharedStorageLockManager manages the state of the locks and locked requests. It acts as the LockRequest receiver to listen to Granted() calls to resolve those requests. The locks uses the shared storage origin as the partitioning origin, and thus can interact with the regular Web Locks API (i.e. navigator.locks.request()) from within the shared storage worklet. The locking function is gated behind features::kSharedStorageWebLocks, which is checked in the browser process in SharedStorageLockManager::SharedStorageUpdate(). Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: I7003d392076a65a9ff2d277f9f0c2791436d2f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020796 Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1387751} -- wpt-commits: 7e168195e3629f88bef6293c18ae8674f90893fd wpt-pr: 49359

…ion for methods from response headers, a=testonly Automatic update from web-platform-tests [shared storage] Implement with_lock option for methods from response headers Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 How: - Add the parameter parsing logic in the network service, and send the final request to the browser process's central SharedStorageLockManager component. - Since SharedStorageLockManager::SharedStorageUpdate() hides the exact database result, we update observer's OnMethodFinished()'s parameters accordingly. In the test observer, the error message is further transformed into a boolean 'success' result. This callback is only used in tests and it's not important to assert the detailed result anyway. - A new test, `SharedStorageHeaderObserverTest.Append_NoCapacity`, has been added to demonstrate the case where `SharedStorageUpdate` encounters an error. Bug: 373899210 Change-Id: I4588c83174d465e7248cc1f41c9b7a693aa326f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042601 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388298} -- wpt-commits: 7658fedd9f51c501150e3b70705e48e81887a095 wpt-pr: 49376

…odifier options for Window and SharedStorageWorklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement 'with_lock' modifier options for Window and SharedStorageWorklet Implement the { withLock: <lock resource name> } option for the modifier methods for Window and SharedStorageWorklet context. The SharedStorageLockManager manages the state of the locks and locked requests. It acts as the LockRequest receiver to listen to Granted() calls to resolve those requests. The locks uses the shared storage origin as the partitioning origin, and thus can interact with the regular Web Locks API (i.e. navigator.locks.request()) from within the shared storage worklet. The locking function is gated behind features::kSharedStorageWebLocks, which is checked in the browser process in SharedStorageLockManager::SharedStorageUpdate(). Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: I7003d392076a65a9ff2d277f9f0c2791436d2f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020796 Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1387751} -- wpt-commits: 7e168195e3629f88bef6293c18ae8674f90893fd wpt-pr: 49359

…ion for methods from response headers, a=testonly Automatic update from web-platform-tests [shared storage] Implement with_lock option for methods from response headers Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 How: - Add the parameter parsing logic in the network service, and send the final request to the browser process's central SharedStorageLockManager component. - Since SharedStorageLockManager::SharedStorageUpdate() hides the exact database result, we update observer's OnMethodFinished()'s parameters accordingly. In the test observer, the error message is further transformed into a boolean 'success' result. This callback is only used in tests and it's not important to assert the detailed result anyway. - A new test, `SharedStorageHeaderObserverTest.Append_NoCapacity`, has been added to demonstrate the case where `SharedStorageUpdate` encounters an error. Bug: 373899210 Change-Id: I4588c83174d465e7248cc1f41c9b7a693aa326f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042601 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388298} -- wpt-commits: 7658fedd9f51c501150e3b70705e48e81887a095 wpt-pr: 49376

…odifier options for Window and SharedStorageWorklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement 'with_lock' modifier options for Window and SharedStorageWorklet Implement the { withLock: <lock resource name> } option for the modifier methods for Window and SharedStorageWorklet context. The SharedStorageLockManager manages the state of the locks and locked requests. It acts as the LockRequest receiver to listen to Granted() calls to resolve those requests. The locks uses the shared storage origin as the partitioning origin, and thus can interact with the regular Web Locks API (i.e. navigator.locks.request()) from within the shared storage worklet. The locking function is gated behind features::kSharedStorageWebLocks, which is checked in the browser process in SharedStorageLockManager::SharedStorageUpdate(). Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: I7003d392076a65a9ff2d277f9f0c2791436d2f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020796 Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1387751} -- wpt-commits: 7e168195e3629f88bef6293c18ae8674f90893fd wpt-pr: 49359 UltraBlame original commit: 452dfd2d01858996047826957a14f49748455f2f

…ion for methods from response headers, a=testonly Automatic update from web-platform-tests [shared storage] Implement with_lock option for methods from response headers Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 How: - Add the parameter parsing logic in the network service, and send the final request to the browser process's central SharedStorageLockManager component. - Since SharedStorageLockManager::SharedStorageUpdate() hides the exact database result, we update observer's OnMethodFinished()'s parameters accordingly. In the test observer, the error message is further transformed into a boolean 'success' result. This callback is only used in tests and it's not important to assert the detailed result anyway. - A new test, `SharedStorageHeaderObserverTest.Append_NoCapacity`, has been added to demonstrate the case where `SharedStorageUpdate` encounters an error. Bug: 373899210 Change-Id: I4588c83174d465e7248cc1f41c9b7a693aa326f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042601 Reviewed-by: Gary Kacmarcik <garykacchromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Reviewed-by: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Kenichi Ishibashi <bashichromium.org> Reviewed-by: Hidehiko Abe <hidehikochromium.org> Reviewed-by: Joe Mason <joenotcharlesgoogle.com> Reviewed-by: Rakina Zata Amni <rakinachromium.org> Cr-Commit-Position: refs/heads/main{#1388298} -- wpt-commits: 7658fedd9f51c501150e3b70705e48e81887a095 wpt-pr: 49376 UltraBlame original commit: 880a4df5d51660e9cb2d441528e85800b42a9315

…odifier options for Window and SharedStorageWorklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement 'with_lock' modifier options for Window and SharedStorageWorklet Implement the { withLock: <lock resource name> } option for the modifier methods for Window and SharedStorageWorklet context. The SharedStorageLockManager manages the state of the locks and locked requests. It acts as the LockRequest receiver to listen to Granted() calls to resolve those requests. The locks uses the shared storage origin as the partitioning origin, and thus can interact with the regular Web Locks API (i.e. navigator.locks.request()) from within the shared storage worklet. The locking function is gated behind features::kSharedStorageWebLocks, which is checked in the browser process in SharedStorageLockManager::SharedStorageUpdate(). Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 Bug: 373899210 Change-Id: I7003d392076a65a9ff2d277f9f0c2791436d2f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020796 Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1387751} -- wpt-commits: 7e168195e3629f88bef6293c18ae8674f90893fd wpt-pr: 49359 UltraBlame original commit: 452dfd2d01858996047826957a14f49748455f2f

…ion for methods from response headers, a=testonly Automatic update from web-platform-tests [shared storage] Implement with_lock option for methods from response headers Explainer PR(s): - WICG/shared-storage#199 - WICG/shared-storage#205 How: - Add the parameter parsing logic in the network service, and send the final request to the browser process's central SharedStorageLockManager component. - Since SharedStorageLockManager::SharedStorageUpdate() hides the exact database result, we update observer's OnMethodFinished()'s parameters accordingly. In the test observer, the error message is further transformed into a boolean 'success' result. This callback is only used in tests and it's not important to assert the detailed result anyway. - A new test, `SharedStorageHeaderObserverTest.Append_NoCapacity`, has been added to demonstrate the case where `SharedStorageUpdate` encounters an error. Bug: 373899210 Change-Id: I4588c83174d465e7248cc1f41c9b7a693aa326f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042601 Reviewed-by: Gary Kacmarcik <garykacchromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Reviewed-by: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Kenichi Ishibashi <bashichromium.org> Reviewed-by: Hidehiko Abe <hidehikochromium.org> Reviewed-by: Joe Mason <joenotcharlesgoogle.com> Reviewed-by: Rakina Zata Amni <rakinachromium.org> Cr-Commit-Position: refs/heads/main{#1388298} -- wpt-commits: 7658fedd9f51c501150e3b70705e48e81887a095 wpt-pr: 49376 UltraBlame original commit: 880a4df5d51660e9cb2d441528e85800b42a9315

Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58

Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401673}

… worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeant@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401696}

… worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5

… worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403952}

….batchUpdate() for PA worklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement sharedStorage.batchUpdate() for PA worklet Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401673} -- wpt-commits: 078605da614507d4428c3cc92040ad750959018f wpt-pr: 49893

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeant@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401696} -- wpt-commits: 7ceee79ca23ba6491a966206a7a6c34c3738fe60 wpt-pr: 49895

….batchUpdate() for PA worklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement sharedStorage.batchUpdate() for PA worklet Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401673} -- wpt-commits: 078605da614507d4428c3cc92040ad750959018f wpt-pr: 49893

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeant@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401696} -- wpt-commits: 7ceee79ca23ba6491a966206a7a6c34c3738fe60 wpt-pr: 49895

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Reland "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403952} -- wpt-commits: 7d409e8d192247cc8131665c486977213b925257 wpt-pr: 49976

Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401673}

… worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeant@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401696}

… worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403952}

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Reland "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403952} -- wpt-commits: 7d409e8d192247cc8131665c486977213b925257 wpt-pr: 49976

….batchUpdate() for PA worklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement sharedStorage.batchUpdate() for PA worklet Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxiachromium.org> Reviewed-by: Maks Orlovich <morlovichchromium.org> Reviewed-by: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Cr-Commit-Position: refs/heads/main{#1401673} -- wpt-commits: 078605da614507d4428c3cc92040ad750959018f wpt-pr: 49893 UltraBlame original commit: 6c9bb3d400ca57aa2228bc148ec78a317433e0bc

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxiachromium.org> > Reviewed-by: Maks Orlovich <morlovichchromium.org> > Reviewed-by: Cammie Smith Barnes <cammiechromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> > Cr-Commit-Position: refs/heads/main{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeantchromium.org> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeantchromium.org> Cr-Commit-Position: refs/heads/main{#1401696} -- wpt-commits: 7ceee79ca23ba6491a966206a7a6c34c3738fe60 wpt-pr: 49895 UltraBlame original commit: 6cd08500ad8b64636cf150d3d9d253e48705bedd

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Reland "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxiachromium.org> > Reviewed-by: Maks Orlovich <morlovichchromium.org> > Reviewed-by: Cammie Smith Barnes <cammiechromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> > Cr-Commit-Position: refs/heads/main{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovichchromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1403952} -- wpt-commits: 7d409e8d192247cc8131665c486977213b925257 wpt-pr: 49976 UltraBlame original commit: 3a359b9243066e47f2bbe59b772e85fd2f96ed7d

….batchUpdate() for PA worklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement sharedStorage.batchUpdate() for PA worklet Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxiachromium.org> Reviewed-by: Maks Orlovich <morlovichchromium.org> Reviewed-by: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Cr-Commit-Position: refs/heads/main{#1401673} -- wpt-commits: 078605da614507d4428c3cc92040ad750959018f wpt-pr: 49893 UltraBlame original commit: 6c9bb3d400ca57aa2228bc148ec78a317433e0bc

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxiachromium.org> > Reviewed-by: Maks Orlovich <morlovichchromium.org> > Reviewed-by: Cammie Smith Barnes <cammiechromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> > Cr-Commit-Position: refs/heads/main{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeantchromium.org> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeantchromium.org> Cr-Commit-Position: refs/heads/main{#1401696} -- wpt-commits: 7ceee79ca23ba6491a966206a7a6c34c3738fe60 wpt-pr: 49895 UltraBlame original commit: 6cd08500ad8b64636cf150d3d9d253e48705bedd

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Reland "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxiachromium.org> > Reviewed-by: Maks Orlovich <morlovichchromium.org> > Reviewed-by: Cammie Smith Barnes <cammiechromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> > Cr-Commit-Position: refs/heads/main{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovichchromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1403952} -- wpt-commits: 7d409e8d192247cc8131665c486977213b925257 wpt-pr: 49976 UltraBlame original commit: 3a359b9243066e47f2bbe59b772e85fd2f96ed7d

….batchUpdate() for PA worklet, a=testonly Automatic update from web-platform-tests [shared storage] Implement sharedStorage.batchUpdate() for PA worklet Add sharedStorage.batchUpdate() function. Parse arguments into the 'methods' sequence and a 'with_lock' optional flag, and propagate the result to the browser process to invoke the `SharedStorageLockManager::SharedStorageBatchUpdate()` API. This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web Lock integration proposal: - WICG/shared-storage#199 - WICG/shared-storage#205 Fuchsia-Binary-Size: Size increase is unavoidable. Bug: 373899210 Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 Commit-Queue: Yao Xiao <yaoxiachromium.org> Reviewed-by: Maks Orlovich <morlovichchromium.org> Reviewed-by: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Cr-Commit-Position: refs/heads/main{#1401673} -- wpt-commits: 078605da614507d4428c3cc92040ad750959018f wpt-pr: 49893 UltraBlame original commit: 6c9bb3d400ca57aa2228bc148ec78a317433e0bc

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af. Reason for revert: New tests are failing on linux-chromeos-dbg: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxiachromium.org> > Reviewed-by: Maks Orlovich <morlovichchromium.org> > Reviewed-by: Cammie Smith Barnes <cammiechromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> > Cr-Commit-Position: refs/heads/main{#1401673} Bug: 373899210 Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546 Owners-Override: Tim Sergeant <tsergeantchromium.org> Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com> Commit-Queue: Tim Sergeant <tsergeantchromium.org> Cr-Commit-Position: refs/heads/main{#1401696} -- wpt-commits: 7ceee79ca23ba6491a966206a7a6c34c3738fe60 wpt-pr: 49895 UltraBlame original commit: 6cd08500ad8b64636cf150d3d9d253e48705bedd

…dStorage.batchUpdate() for PA worklet", a=testonly Automatic update from web-platform-tests Reland "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <yaoxiachromium.org> > Reviewed-by: Maks Orlovich <morlovichchromium.org> > Reviewed-by: Cammie Smith Barnes <cammiechromium.org> > Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> > Cr-Commit-Position: refs/heads/main{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <morlovichchromium.org> Reviewed-by: Giovanni Ortuno Urquidi <ortunochromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1403952} -- wpt-commits: 7d409e8d192247cc8131665c486977213b925257 wpt-pr: 49976 UltraBlame original commit: 3a359b9243066e47f2bbe59b772e85fd2f96ed7d

xyaoinum requested review from pythagoraskitty and jkarlin October 31, 2024 20:09

minor: 'first' -> 'last'

8224918

xyaoinum added 2 commits November 5, 2024 17:14

Improve examples

d74ace9

Improve example

4006d11

jkarlin approved these changes Nov 7, 2024

View reviewed changes

README.md Show resolved Hide resolved

Update example to include lock in an operation

f899a9a

pythagoraskitty approved these changes Nov 11, 2024

View reviewed changes

xyaoinum merged commit 44ecf99 into main Nov 11, 2024
1 check passed

xyaoinum deleted the yao-update-web-locks-header branch November 14, 2024 17:43

chromium-wpt-export-bot mentioned this pull request Nov 25, 2024

[shared storage] Implement 'with_lock' modifier options for Window and SharedStorageWorklet web-platform-tests/wpt#49359

Merged

chromium-wpt-export-bot mentioned this pull request Nov 26, 2024

[shared storage] Implement with_lock option for methods from response headers web-platform-tests/wpt#49376

Merged

chromium-wpt-export-bot mentioned this pull request Jan 3, 2025

[shared storage] Implement sharedStorage.batchUpdate() for PA worklet web-platform-tests/wpt#49893

Merged

chromium-wpt-export-bot mentioned this pull request Jan 3, 2025

Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" web-platform-tests/wpt#49895

Merged

chromium-wpt-export-bot mentioned this pull request Jan 8, 2025

Reland "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet" web-platform-tests/wpt#49976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle Shared-Storage-Write as a single batchUpdate(); Respect withLo… #205

Handle Shared-Storage-Write as a single batchUpdate(); Respect withLo… #205

xyaoinum commented Oct 31, 2024 •

edited

Loading

xyaoinum commented Oct 31, 2024

pythagoraskitty commented Nov 5, 2024

xyaoinum commented Nov 5, 2024

jkarlin left a comment

Handle Shared-Storage-Write as a single batchUpdate(); Respect withLo… #205

Handle Shared-Storage-Write as a single batchUpdate(); Respect withLo… #205

Conversation

xyaoinum commented Oct 31, 2024 • edited Loading

xyaoinum commented Oct 31, 2024

pythagoraskitty commented Nov 5, 2024

xyaoinum commented Nov 5, 2024

jkarlin left a comment

Choose a reason for hiding this comment

xyaoinum commented Oct 31, 2024 •

edited

Loading