[spec] Support custom dataOrigin in createWorklet
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec update for #198
xyaoinum
reviewed
Nov 6, 2024
pythagoraskitty
commented
Nov 8, 2024
| @@ -178,6 +178,9 @@ spec: shared-storage-explainer; urlPrefix: https://github.com/WICG/shared-storag | |||
| spec: UUID; urlPrefix: https://www.ietf.org/rfc/rfc4122.txt | |||
| type: dfn | |||
| text: urn uuid; url: urn-uuid | |||
| spec: hr-time; urlPrefix: https://w3c.github.io/hr-time/ | |||
There was a problem hiding this comment.
I just added this anchor because suddenly the spec stopped being able to find [=/current wall time=] on its own.
|
@wanderview Could you please take a look? Thanks! |
wanderview
requested changes
Nov 11, 2024
wanderview
approved these changes
Nov 13, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 13, 2024
SHA: adc7252 Reason: push, by pythagoraskitty Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 27, 2024
We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388907}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 27, 2024
We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388907}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 27, 2024
We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388907}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 28, 2024
…in in createWorklet, a=testonly Automatic update from web-platform-tests Shared Storage: Support custom data origin in createWorklet We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388907} -- wpt-commits: d8ae479d673d32ab3dc69e08e1f0529c71769027 wpt-pr: 49405
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 30, 2024
…in in createWorklet, a=testonly Automatic update from web-platform-tests Shared Storage: Support custom data origin in createWorklet We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1388907} -- wpt-commits: d8ae479d673d32ab3dc69e08e1f0529c71769027 wpt-pr: 49405
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 1, 2024
…in in createWorklet, a=testonly Automatic update from web-platform-tests Shared Storage: Support custom data origin in createWorklet We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashichromium.org> Commit-Queue: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Yao Xiao <yaoxiachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Reviewed-by: Mike West <mkwstchromium.org> Cr-Commit-Position: refs/heads/main{#1388907} -- wpt-commits: d8ae479d673d32ab3dc69e08e1f0529c71769027 wpt-pr: 49405 UltraBlame original commit: f74a9d288ec2e48dc358339b778fc966fb37d1e0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 1, 2024
…in in createWorklet, a=testonly Automatic update from web-platform-tests Shared Storage: Support custom data origin in createWorklet We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashichromium.org> Commit-Queue: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Yao Xiao <yaoxiachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Reviewed-by: Mike West <mkwstchromium.org> Cr-Commit-Position: refs/heads/main{#1388907} -- wpt-commits: d8ae479d673d32ab3dc69e08e1f0529c71769027 wpt-pr: 49405 UltraBlame original commit: f74a9d288ec2e48dc358339b778fc966fb37d1e0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 1, 2024
…in in createWorklet, a=testonly Automatic update from web-platform-tests Shared Storage: Support custom data origin in createWorklet We add support for custom data origins. See WICG/shared-storage#198 and WICG/shared-storage#206. Bug: 376278213 Change-Id: I7589ef08e68a8ec416d5ba1b986a81974f3e34d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5996831 Reviewed-by: Kenichi Ishibashi <bashichromium.org> Commit-Queue: Cammie Smith Barnes <cammiechromium.org> Reviewed-by: Yao Xiao <yaoxiachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Reviewed-by: Mike West <mkwstchromium.org> Cr-Commit-Position: refs/heads/main{#1388907} -- wpt-commits: d8ae479d673d32ab3dc69e08e1f0529c71769027 wpt-pr: 49405 UltraBlame original commit: f74a9d288ec2e48dc358339b778fc966fb37d1e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec update for #198.
This will make it possible for a worklet script to use shared storage data from an arbitrary origin other than the worklet script's origin or the invoking context's origin. The data origin would have to opt-in for data use to occur, as data processing could modify the data origin's data, send reports, and would affect its shared storage privacy budget.
Preview | Diff