Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sharedStorage aware of size + hook into fenced frame changes #51

Closed
wants to merge 1 commit into from

Conversation

gtanzer
Copy link

@gtanzer gtanzer commented Dec 13, 2022

See WICG/fenced-frame#56, and analogous changes to FLEDGE in WICG/turtledove#417 .

Basically, now you need to declare a size across all urls to be selected, and that size is part of the k-anonymity check that was previously just the URL.

This has a number of benefits, like:

  • Privacy: In the old design, there was wiggle room for the embedder to cause observable differences inside the fenced frame by its choice of the size. In the new design, we close this gap by running the k-anonymity check on the totality of information that flows from the embedder into the fenced frame.
  • Flexibility: Due to the privacy improvements above, we no longer need to stipulate a list of allowed sizes.

@gtanzer
Copy link
Author

gtanzer commented Apr 7, 2023

In light of the changes in #69, these size changes are no longer necessary. Instead, all size restrictions (i.e. size freezing, a size allowist) for selectURL fenced frames will be removed, as any information that enters the fenced frame through the size could have instead been communicated in through the url.

@gtanzer gtanzer closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant