-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature representation. #16
Comments
(This would also address @ddworken's request for some kind of |
That's correct. And browsers would have a hard(er) time implementing checks before content codings are handled. |
Reading more carefully, it looks like both In any event, if the description of the headers above matches your understanding, @LPardue, then I'd like to help you get |
Rather than inventing an `Integrity` header, this patch shifts onto RFC9421's HTTP Message Signature mechanism for signature definition and delivery, alongside the `Identity-Digest` proposal that's still working its way through the IETF. This should address the core of #16.
I took a pass at shifting the proposal over to the mechanism proposed here. @LPardue (and anyone else who's interested!), would you mind skimming https://wicg.github.io/signature-based-sri/#validation and suggesting any improvements that occur to you? |
Closing this out. For the moment, the approach in https://wicg.github.io/signature-based-sri/#validation seems like a reasonable way to approach this. There's likely followup work, but we can address it in more specific bugs. |
In WICG/proposals#175 (comment), @LPardue suggested that we rely upon HTTP Message Signatures (https://www.rfc-editor.org/rfc/rfc9421.html) rather than inventing a new header, which sounds like a wonderful idea indeed. That would look something like the following:
HTML indicates the expected key:
The request/response would look like:
I'm not interested in inventing something new here if we don't have to, so I'm happy to rely on the mechanism described here. It's pretty verbose (I'll dig through the spec to figure out which parts are required/optional, but I guess that's more or less the minimal set?), but would do what we need it to.
That said, I'm a little confused about the differences between
Repr-Digest
on the one hand, and the proposedIdentity-Digest
on the other. SRI currently operates over the bytes that remain after the content is decoded per itscontent-encoding
. @annevk to keep me honest on this, but that's my recollection and read of the current flow in Fetch (we handle content codings in HTTP-network Fetch, and pass those bytes back down to perform the SRI check at the bottom of Main Fetch). Does one of the headers described here represent those decoded bytes?The text was updated successfully, but these errors were encountered: