Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does "Click" literally mean just click event? What about other (accessible) ways of activating navigations via user action? #3

Closed
mmocny opened this issue Oct 6, 2022 · 12 comments

Comments

@mmocny
Copy link

mmocny commented Oct 6, 2022

Alongside of "click" events you could have other events fire (pointer, focus, change, etc). If one of those kicks off the navigation, presumably those could be a separate Task Attribution tree? And it could meet all the other criteria

Also, it seems possible to navigate using alternative inputs, which are still user driven, and which are still semantic, but that don't involve a "click" event at all. Perhaps using keyboard to navigate an application that offers keyboard shortcuts, or using keyboard to activate form elements (change or submit). Some of these may or may not fire click as well, I think.

@yoavweiss
Copy link
Collaborator

For some reason, I thought that "click" event also covers keyboard based "clicks". I now see that I was partially right: it does for buttons, but not for <a> based links.

Do you have a sense of which event types we would need to cover in order to properly capture keyboard based SPA navigations?

@mmocny
Copy link
Author

mmocny commented Oct 13, 2022

I thought that "click" event also covers keyboard based "clicks"

Fun fact! If you actually add an href= to that link, suddenly it will fire click after keyboard activation :)

Other subtle things I've noticed while playing around with keyboard:

  • You can use Space bar to activate click events on buttons and other input elements, but not links.
    • I see references to other button types for activating focused-element (i.e. via Android virtual keyboard/hardware buttons). I suspect these also just fire click.
  • With "Enter" you get the click event on the DOWN part of the interaction. With "Space" you get click on the UP part of the interaction. I haven't audited mobile behaviour to see how exactly it differs.

Do you have a sense of which event types we would need to cover in order to properly capture keyboard based SPA navigations?

Given the above, I think you can probably just rely on click event, if you are only asking specifically about anchors/button activations. I also think that lines up with the default/declarative way to use navigation API.

You likely also want submit event for <form>.

This list breaks down the userInitiated concept and Same-document navigations, and the other things that pop our are: "Browser UI back/forward" (pretty important) and <area> (similar to <a>?).

But, there's a whole other can of worms once you consider programmatic activation since I think that can happen in the context of arbitrary user-initiated events.

Here's an example page that uses programmatic activation (in this case, it actually does it from click event handler... but still doesn't seem to count).

The navigate event in that demo seems to consider these types of programmatic activations as userInitiated: false -- but I'm not sure if that really makes sense in a world with TaskAttribution tracking.

@tunetheweb
Copy link
Contributor

Using Forward and Back browser keyboard shortcuts (e.g. + [/] on Chrome on Mac) can be used to navigate through an SPA, without a click.

Maybe should listen for keyup, keydown, and click events?

@dieulot
Copy link

dieulot commented Nov 24, 2022

Not accessibility related: Something I’ve been thinking about — but is seldom used in the wild — is to trigger navigation on mousedown instead of click (≈ mouseup).

That’s what some parts (though usually not “navigations”) of native interfaces use. Running Windows XP in a VM today feels super fast in part because of a liberal use of mousedown triggers.

You lose some power user advantages (mostly drag and drop, and mousing away to cancel a navigation) but I’m convinced you would come out ahead on user experience for most people. (That’s often a controversial take for power users though.)

It’s not really used in the wild as far as I know though, so not handling that case at least on first release might make sense.

@myfonj
Copy link

myfonj commented Nov 24, 2022

It’s not really used in the wild as far as I know though.

Probably not on the web, but, while not "navigation related", mousedown triggering view state change in most (Windows) desktop applications' menus still adhere to "single click and drag" tradition:

  • open list with mousedown,
  • open sub-list with mouseenter (:hover if you will),
  • trigger item on mouseup".

So in Edge for example you can "drag" from triple dot menu button, through "Help and Feedback" and release mouse on "About Edge" to trigger it. This mechanism is pretty common in Windows desktop UI. Notable exceptions are Firefox' triple dash menu (but not regular "alt menu") and Windows 10 Start menu, what is a shame. (Windows XP start menu tree was definitely single-clickable.)

so not handling that case at least on first release might make sense.

Yes, from accessibility/portability point of view, I think such feature must be only supplemental to "normal" multiple discrete click/tap approach.

@yoavweiss
Copy link
Collaborator

Using Forward and Back browser keyboard shortcuts (e.g. + [/] on Chrome on Mac) can be used to navigate through an SPA, without a click.

Interesting! What events does the SPA use to support this? popstate? navigate? Something else?

@mmocny
Copy link
Author

mmocny commented Nov 24, 2022

What events does the SPA use to support this? popstate? navigate? Something else?

Likely so. It looks like we fire popstate for both "forward" and "back" navs, and the new navigate event as well. navigate also fires for form submit.

Something else?

I know for example that Esc key and modal dialogs were part of the research efforts during Navigation API development. The solutions for modal ended up mostly distinct, but I wonder if you can treat Esc as a form of spa nav...


Q: why is it important to hook onto click specifically? What about just using any Input that was considered a user Interaction? Then we could have similar concepts for Events, Layout Shifts, Paint algorithms, etc.

@tunetheweb
Copy link
Contributor

As discussed, GitHub's keyboard shortcuts (type ? to see them) are another good example of actual navs - outside of the history api example I gave above.

For example typing gi on this page (outside of a text input) will take you to the main Issues tab.

@zcorpan
Copy link

zcorpan commented Nov 24, 2022

@yoavweiss

For some reason, I thought that "click" event also covers keyboard based "clicks". I now see that I was partially right: it does for buttons, but not for <a> based links.

Your test is "wrong" because you have no href attribute and, therefore, it's not a link. Keyboard activation for <a href> fires click. See http://software.hixie.ch/utilities/js/live-dom-viewer/saved/11055

Spec: https://html.spec.whatwg.org/multipage/interaction.html#activation

@yoavweiss
Copy link
Collaborator

Thanks @zcorpan for pointing out where I got things wrong!

With that in mind, I think the only case worth considering is the one Barry mentioned - that of keyboard shortcuts. I wonder if/how we can capture that without triggering the heuristic on every text input..

@yoavweiss
Copy link
Collaborator

Maybe a keydown event whose target is either the body/root element can be considered similarly to "click" for the heuristic purposes. That way it doesn't capture any input on a focused element.

@yoavweiss
Copy link
Collaborator

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 5, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3
Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 5, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3
Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 5, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3
Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3
Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3
Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3

Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193004}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2023
Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3

Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193004}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 13, 2023
…on triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 13, 2023
…on triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1196100}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 13, 2023
…on triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1196100}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 13, 2023
…cuts as soft navigation triggers, a=testonly

Automatic update from web-platform-tests
[soft navigations] Enable keyboard shortcuts as soft navigation triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3

Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193004}

--

wpt-commits: 7f165f11361b86ef41b123dbc904ccee26d5f025
wpt-pr: 41816
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Sep 14, 2023
…cuts as soft navigation triggers, a=testonly

Automatic update from web-platform-tests
[soft navigations] Enable keyboard shortcuts as soft navigation triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3

Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193004}

--

wpt-commits: 7f165f11361b86ef41b123dbc904ccee26d5f025
wpt-pr: 41816
OrKoN pushed a commit to web-platform-tests/wpt that referenced this issue Sep 18, 2023
…on triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1196100}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 28, 2023
…on triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 28, 2023
…rd shortcuts as soft navigation triggers", a=testonly

Automatic update from web-platform-tests
Revert "[soft navigations] Enable keyboard shortcuts as soft navigation triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1196100}

--

wpt-commits: 40543949faa61279ddd3341accfe9ea866a5987e
wpt-pr: 41958
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 29, 2023
…rd shortcuts as soft navigation triggers", a=testonly

Automatic update from web-platform-tests
Revert "[soft navigations] Enable keyboard shortcuts as soft navigation triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Hao Liu <haoliukchromium.org>
Owners-Override: Daniel Cheng <dchengchromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main{#1196100}

--

wpt-commits: 40543949faa61279ddd3341accfe9ea866a5987e
wpt-pr: 41958

UltraBlame original commit: 75ec63eee316694d3fe0839d1806cf0c63f9a397
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 29, 2023
…rd shortcuts as soft navigation triggers", a=testonly

Automatic update from web-platform-tests
Revert "[soft navigations] Enable keyboard shortcuts as soft navigation triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Hao Liu <haoliukchromium.org>
Owners-Override: Daniel Cheng <dchengchromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main{#1196100}

--

wpt-commits: 40543949faa61279ddd3341accfe9ea866a5987e
wpt-pr: 41958

UltraBlame original commit: 75ec63eee316694d3fe0839d1806cf0c63f9a397
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Sep 30, 2023
…rd shortcuts as soft navigation triggers", a=testonly

Automatic update from web-platform-tests
Revert "[soft navigations] Enable keyboard shortcuts as soft navigation triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1196100}

--

wpt-commits: 40543949faa61279ddd3341accfe9ea866a5987e
wpt-pr: 41958
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 30, 2023
…rd shortcuts as soft navigation triggers", a=testonly

Automatic update from web-platform-tests
Revert "[soft navigations] Enable keyboard shortcuts as soft navigation triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue #3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweisschromium.org>
> Reviewed-by: Ian Clelland <iclellandchromium.org>
> Cr-Commit-Position: refs/heads/main{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Hao Liu <haoliukchromium.org>
Owners-Override: Daniel Cheng <dchengchromium.org>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main{#1196100}

--

wpt-commits: 40543949faa61279ddd3341accfe9ea866a5987e
wpt-pr: 41958

UltraBlame original commit: 75ec63eee316694d3fe0839d1806cf0c63f9a397
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 2, 2023
…on triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203903}
aarongable pushed a commit to chromium/chromium that referenced this issue Oct 2, 2023
…on triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203903}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 2, 2023
…on triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203903}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 4, 2023
…rd shortcuts as soft navigation triggers, a=testonly

Automatic update from web-platform-tests
Reland: [soft navigations] Enable keyboard shortcuts as soft navigation triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203903}

--

wpt-commits: 04ab10bfca7454a6f6d968cb6c9c697fcdea9de2
wpt-pr: 42213
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Oct 5, 2023
…rd shortcuts as soft navigation triggers, a=testonly

Automatic update from web-platform-tests
Reland: [soft navigations] Enable keyboard shortcuts as soft navigation triggers

Following the discussion on issue #3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203903}

--

wpt-commits: 04ab10bfca7454a6f6d968cb6c9c697fcdea9de2
wpt-pr: 42213
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
Following the discussion on issue web-platform-tests#3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

[1] WICG/soft-navigations#3

Bug: 1478772
Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1193004}
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
…on triggers"

This reverts commit 6efe71286a014d3d3872bc990e3ea2d08dd46dba.

Reason for revert: One check added in this CL causes crash. see
crbug.com/1480047

Original change's description:
> [soft navigations] Enable keyboard shortcuts as soft navigation triggers
>
> Following the discussion on issue web-platform-tests#3 [1], this CL adds support to soft
> navigations triggered by keyboard shortcuts, by adding unfocused keydown
> events to the events that can trigger the soft navigation heuristic.
>
> [1] WICG/soft-navigations#3
>
> Bug: 1478772
> Change-Id: Ib423a3cfc09eaf4dd9a2221b3494ab1016fa8668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839506
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1193004}

Bug: 1478772
Change-Id: I3a518c165e6b19239a6bf7900e94c1ef9c3e5a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859802
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Hao Liu <haoliuk@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1196100}
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this issue Dec 11, 2023
…on triggers

Following the discussion on issue web-platform-tests#3 [1], this CL adds support to soft
navigations triggered by keyboard shortcuts, by adding unfocused keydown
events to the events that can trigger the soft navigation heuristic.

This is a reland of [2], rebased and which fixes the unguarded
ScriptState access in event_dispatcher, which caused a crash.

[1] WICG/soft-navigations#3
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4839506

Bug: 1478772, 1480047
Change-Id: I6428e0635222366d880dd908f04f2273b6bf8b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4900577
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203903}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants