Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #45

Closed
wants to merge 5 commits into from
Closed

Test #45

wants to merge 5 commits into from

Conversation

evanstade
Copy link
Collaborator

@evanstade evanstade commented Dec 22, 2022

Add bucket durability and IndexedDB text.


Preview | Diff

@evanstade
Copy link
Collaborator Author

ptal. Note the variable durability verbiage:

  • IDB durability MAY be respected (see idb spec)
  • StorageBucketOptions durability MAY be respected when creating the bucket
  • Bucket's durability MUST be respected (i.e. should reflect what the user agent is going to do)

Copy link
Collaborator

@ayuishii ayuishii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Overall LGTM, just a few questions.

index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
Copy link
Collaborator

@ayuishii ayuishii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
Each {{StorageBucket}} has an {{IDBFactory}} object. {{IDBDatabase}} objects created by
{{StorageBucket/indexedDB}} are associated with the bucket.

The user agent should consider the associated {{StorageBucket/durability}} when evaluating the <a spec="IndexedDB">durability hint</a> |durability|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just noticed. Should this be surrounded by <div algorithm></div>?

Seems like a common pattern I see when explaining method steps ex [1].

[1] https://github.com/w3c/IndexedDB/blob/main/index.bs#L1114

@evanstade evanstade closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants