Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started on explainer stuff for multi-bid #1048

Merged
merged 13 commits into from
Apr 16, 2024

Conversation

morlovich
Copy link
Collaborator

This isn't ready for review yet, but it's been suggested this may be useful to have as a focus of discussion.

@dmdabbs
Copy link
Contributor

dmdabbs commented Feb 22, 2024

Appreciate you putting a starter out there as https://issues.chromium.org/issues/323856489 progresses.

FLEDGE.md Show resolved Hide resolved
@morlovich
Copy link
Collaborator Author

... Also this clearly needs to mention that perBuyerMultiBidLimits is a thing.

@dmdabbs
Copy link
Contributor

dmdabbs commented Feb 23, 2024

... Also this clearly needs to mention that perBuyerMultiBidLimits is a thing.

Oy, another buyer-origin-keyed attribute. Can't live with 'em, can't live without 'em. ¯\(ツ)/¯.

@morlovich
Copy link
Collaborator Author

Started on spec stuff as well:
https://github.com/WICG/turtledove/pull/1055/files#

@dmdabbs
Copy link
Contributor

dmdabbs commented Feb 27, 2024

Reading over @morlovich's spec work, I see that setBid() is upgraded to accept multiple bids. The spec and "release notes" docs reference it nbut not teh explainer. Would it be out of bounds for this PR to include it?

@morlovich
Copy link
Collaborator Author

morlovich commented Feb 29, 2024

Reading over @morlovich's spec work, I see that setBid() is upgraded to accept multiple bids. The spec and "release notes" docs reference it nbut not teh explainer. Would it be out of bounds for this PR to include it?

Looks like the explainer completely neglected it; added it here (especially since the whole "used when generateBid throws" part is unusual)

FLEDGE.md Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
PA_Feature_Detecting.md Outdated Show resolved Hide resolved
PA_Feature_Detecting.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@morlovich morlovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback applied. Hopefully accurately.

FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
PA_Feature_Detecting.md Outdated Show resolved Hide resolved
PA_Feature_Detecting.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Show resolved Hide resolved
This was referenced Apr 16, 2024
@JensenPaul JensenPaul merged commit c2ca63a into WICG:main Apr 16, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 16, 2024
SHA: c2ca63a
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to morlovich/turtledove that referenced this pull request Apr 16, 2024
SHA: c2ca63a
Reason: push, by morlovich

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
`generateBid()` can permit the browser to select a subset of returned component ads
that pass the k-anonymity threshold.

Note that feature detection for this in Chrome is the same as for multiple bid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this feature detection mechanism proprietary? Or is it well-specified?

If it's the latter, please remove the "in Chrome" reference from the explainer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way we have been spec'ing it as always returning constants:
https://wicg.github.io/turtledove/#feature-detection
The hope is that a full implementation will support all of it.

Perhaps if/when someone else implements it they'll find it helpful to not support it in need of incremental development as well, however.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants