-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started on explainer stuff for multi-bid #1048
Conversation
Appreciate you putting a starter out there as https://issues.chromium.org/issues/323856489 progresses. |
... Also this clearly needs to mention that perBuyerMultiBidLimits is a thing. |
Oy, another buyer-origin-keyed attribute. Can't live with 'em, can't live without 'em. ¯\(ツ)/¯. |
Started on spec stuff as well: |
Reading over @morlovich's spec work, I see that |
Looks like the explainer completely neglected it; added it here (especially since the whole "used when generateBid throws" part is unusual) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback applied. Hopefully accurately.
SHA: c2ca63a Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: c2ca63a Reason: push, by morlovich Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
`generateBid()` can permit the browser to select a subset of returned component ads | ||
that pass the k-anonymity threshold. | ||
|
||
Note that feature detection for this in Chrome is the same as for multiple bid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature detection mechanism proprietary? Or is it well-specified?
If it's the latter, please remove the "in Chrome" reference from the explainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way we have been spec'ing it as always returning constants:
https://wicg.github.io/turtledove/#feature-detection
The hope is that a full implementation will support all of it.
Perhaps if/when someone else implements it they'll find it helpful to not support it in need of incremental development as well, however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't ready for review yet, but it's been suggested this may be useful to have as a focus of discussion.