Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify resize and scroll event ordering #80

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

bokand
Copy link
Collaborator

@bokand bokand commented Jan 4, 2022

This PR changes the event dispatch portion of the spec to instead monkey patch the resize and scroll event dispatch steps in CSSOM-View so that the ordering is clear between the visual viewport's scroll and resize as well as in relation to other pending scroll events.

In both resize and scroll cases, the event on the VisualViewport is fired immediately after the corresponding event on the Document.

(Also fixes minor unrelated ReSpec warnings)

Fixes #66
Fixes #65

@bokand
Copy link
Collaborator Author

bokand commented Jan 4, 2022

@rniwa - Could you please take a look (I can't add you as a reviewer) - do these changes satisfy your concerns in #66 and #65?

@bokand
Copy link
Collaborator Author

bokand commented Feb 23, 2022

Ping @rniwa

Or perhaps @smfr, could you take a look, since you edit CSSOM-View?

index.html Outdated Show resolved Hide resolved
@bokand bokand merged commit 06d0911 into WICG:gh-pages Feb 23, 2022
@bokand
Copy link
Collaborator Author

bokand commented Feb 23, 2022

Thanks!

@bokand bokand deleted the specifyEventOrder branch February 23, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants