Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Distributed Nodes Algorithm to Slot Assignment Algorithm #323

Closed
rniwa opened this issue Sep 17, 2015 · 6 comments
Closed

Rename Distributed Nodes Algorithm to Slot Assignment Algorithm #323

rniwa opened this issue Sep 17, 2015 · 6 comments

Comments

@rniwa
Copy link
Collaborator

rniwa commented Sep 17, 2015

Like the issue #322, we should just get rid of the term "distribution" everywhere in the spec. It's unwarranted use of a historical jargon that doesn't merit anyone.

@hayatoito
Copy link
Contributor

One web-exposed API which is using the term "distribution" is slot.getDistributedNodes().

http://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getDistributedNodes-sequence-Node

We need to rename this. How about slot.getComposedNodes()?

Regarding with other usage of the term "distribution" in the spec, we do not have to be in a hurry. We can fix that later.

@hayatoito hayatoito added the v1 label Jan 13, 2016
@rniwa
Copy link
Collaborator Author

rniwa commented Jan 13, 2016

Now about getAssignedNodes() with a boolean argument specifying deep/flatten?

@hayatoito
Copy link
Contributor

I'm fine with getAssignedNodes() with a boolean parameter:

    sequence<Node> getAssignedNodes(optional boolean deep/flatten/oranythingelse);

sequence<Node> could be FrozenArray[Node], that is another issue.

@annevk
Copy link
Collaborator

annevk commented Jan 15, 2016

Please no boolean parameter. Use a dictionary with a single member that defaults to false. We always find out over time we wanted more parameters. And it's better that boolean parameters are named.

@hayatoito
Copy link
Contributor

+1. Let's use a dictionary even when only one parameter is expected, as of now.

@TakayoshiKochi
Copy link
Member

As commented in #361 (comment)
deepPath is for #361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants