Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change for Focus Navigation #447

Merged
merged 4 commits into from
Mar 28, 2016

Conversation

TakayoshiKochi
Copy link
Member

This is updated patch for #381, to address issue #375.

The previous branch went somewhat weird state and recreated a branch.

As discussed in
WICG#375

This adds a clarification about focus navigation order for
nodes distributed under a slot element.

Also added handling tabindex="-1" case.
@TakayoshiKochi
Copy link
Member Author

@hayatoito PTAL
This is a continuation from #381

@hayatoito
Copy link
Contributor

At the first glance, it looks good to me. I'll take another deeper look later.

Given that this is the formal definition, I am afraid that it is not easy to understand how this works actually.
It would be great that we have a simple example.


<p>If a <a>node</a> doesn’t <a data-lt="participates">participate</a> in the <a>document flat tree</a>, the <a>node</a> <strong>must</strong> be skipped from the <a>sequential focus navigation</a>.</p>
<p><dfn>focus navigation scope</dfn> is a set of elements <a>in a composed document</a>. An element belongs to at most one <a>focus navigation scope</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you avoid to use composed document in normative section?

@TakayoshiKochi
Copy link
Member Author

@hayatoito PTAL

@hayatoito hayatoito merged commit a1b519e into WICG:gh-pages Mar 28, 2016
@hayatoito
Copy link
Contributor

I think we can merge this now.
I think it's time to edit this on HEAD. We can improve this anytime.

@TakayoshiKochi TakayoshiKochi deleted the focusScope2 branch March 29, 2016 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants