Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strictly UTF-8 decode the fallback URL #346

Merged
merged 1 commit into from
Dec 5, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions loading.bs
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,9 @@ the result of the following steps:
1. Let |fallbackUrlBytes| be the result of [=read buffer/reading=]
|fallbackUrlLength| bytes from |stream|.
1. If |fallbackUrlBytes| is a failure, return it.
1. Let |fallbackUrl| be the result of [=UTF-8 decode without BOM or fail=] on
|fallbackUrlBytes|.
1. If |fallbackUrl| is a failure, return it.
1. If the result of running the [=URL parser=] on |fallbackUrl| is a failure, if
it has a non-null [=url/fragment=], or if its [=url/scheme=] is something
other than `"https"`, return a failure.
Expand Down