Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to <script>-based API (issue #670) #679

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Switch to <script>-based API (issue #670) #679

merged 3 commits into from
Sep 16, 2021

Conversation

hayatoito
Copy link
Collaborator

Update the explainer so that it uses <script>-based API, instead of
<link>-based API.

Note:

  • The syntax is still tentative. We should align the syntax with ResourceBundles
    (issue Use <script> tag, instead of <link> tag #670).
  • There are still some gaps between <link>-based API and <script>-based API.
    e.g. Request's mode and credentials mode. They should be resolved
    later.

@hayatoito
Switch to <script>-based API (issue WICG#670)
4c6b89e 
Update the explainer so that it uses <script>-based API, instead of
<link>-based API.

Note:
- The syntax is still tentative. We should align the syntax with ResourceBundles
  (issue WICG#670).
- There are still some gaps between <link>-based API and <script>-based API.
  e.g. Request's mode and credentials mode. They should be resolved
  later.
@hayatoito hayatoito requested review from horo-t and irori September 15, 2021 04:58
@hayatoito
Copy link
Collaborator Author

hayatoito commented Sep 15, 2021 •
edited
Loading

@irori @horo-t , could you please review?
There are still gaps between <link> and <script> as mentioned in the comment.
I'd keep issue #670 open. Let's address remaining issues later.

irori
irori reviewed Sep 15, 2021
View reviewed changes
explainers/subresource-loading.md Outdated Show resolved Hide resolved
explainers/subresource-loading.md Outdated Show resolved Hide resolved
@hayatoito
Copy link
Collaborator Author

Thanks for the reviews. Addressed. Could you please take a look again?

irori
irori approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@irori irori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayatoito
Copy link
Collaborator Author

Thanks for the reviews. Let me merge.
We can address remaining issues later, tracked by issue #670.

@hayatoito hayatoito merged commit 725c28c into WICG:main Sep 16, 2021
horo-t
horo-t reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@horo-t horo-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayatoito hayatoito deleted the script-element branch March 7, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horo-t horo-t horo-t left review comments

@irori irori irori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayatoito @irori @horo-t