bump wipac-rest-tools #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blinkdog
requested changes
Apr 22, 2024
| @@ -9,7 +9,7 @@ | |||
| # is zero for an official release, positive for a development branch, | |||
| # or negative for a release candidate or beta (after the base version | |||
| # number has been incremented) | |||
| __version__ = "0.42.0" | |||
| __version__ = "0.41.33" | |||
There was a problem hiding this comment.
So the semantic release tool really didn't like that the master branch code version was ahead of the github tag number. They're supposed to be equal I guess?
There was a problem hiding this comment.
Okay. I guess it doesn't matter so much, it just seemed weird for the version to decrease.
Want to bring my change from #279 in to this PR, and we can close mine and merge this one?
There was a problem hiding this comment.
I think everything in #279 is in here?
There was a problem hiding this comment.
🤦 I missed it the first time.
blinkdog
approved these changes
Apr 22, 2024
| @@ -9,7 +9,7 @@ | |||
| # is zero for an official release, positive for a development branch, | |||
| # or negative for a release candidate or beta (after the base version | |||
| # number has been incremented) | |||
| __version__ = "0.42.0" | |||
| __version__ = "0.41.33" | |||
There was a problem hiding this comment.
🤦 I missed it the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.