Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Admin Notices #180

Closed
wants to merge 2 commits into from
Closed

Better Admin Notices #180

wants to merge 2 commits into from

Conversation

ahmadawais
Copy link

@ahmadawais ahmadawais commented Nov 4, 2016

All admin notices were success green notices. This PR makes them more context specific.

  • Errors
  • Succes
  • Info

Errors

img
img
img

Success

img
img

Info (Default)

img

Looking forward!

@stephenharris
Copy link

Shouldn't 'Updated application' also be green? It is confirmation that the application has successfully updated.

@ahmadawais
Copy link
Author

@stephenharris "Updated Application" in my opinion is an info type notification not really a green signal. Just what I think. I wish this PR would get a bit more attention so that we can discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants