The OAuth callback validator was overly aggressive. Desktop applications... #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons can use the localhost in order to listen for the response from the OAuth server. In addition, it may listen on a non-standard port. This updated code only verifies the scheme and host. It also adds a WP filter that allows localhost in the URL.
sblaz
added a commit
to sblaz/OAuth1
that referenced
this pull request
Jun 2, 2015
sblaz
added a commit
to sblaz/OAuth1
that referenced
this pull request
Jun 5, 2015
|
(Looks like this has been out there for a while, but I'll comment anyway since it's still open and relevant) This issue can be solved outside of the OAuth plugin by using an external plugin that adds the same filter. I wonder if that would make more sense because it could be configured differently per server. |
|
This has been fixed in #98; thanks for the PR anyway! 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... can use the localhost in order to listen for the response from the OAuth server. In addition, it may listen on a non-standard port. This updated code only verifies the scheme and host. It also adds a WP filter that allows localhost in the URL.