Ensure OAuth1 signature is created as per the spec #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblaz
added a commit
to sblaz/OAuth1
that referenced
this pull request
May 29, 2015
…correct-oauth-signature-creation
sblaz
added a commit
to sblaz/OAuth1
that referenced
this pull request
Jun 5, 2015
…correct-oauth-signature-creation Conflicts: lib/class-wp-json-authentication-oauth1.php
|
Update to replace another urldecode with rawurldecode ... fixes issues with signature that contains "+" (they were replaced with spaces) |
|
I think the 2 rawurlencode() calls on line 627 might be unnecessary. I was seeing a double-encoding of my oauth_callback parameter value and it appears an earlier call to normalize_parameters() takes care of things correctly. |
|
In my case, normalize_parameters() is really messing up my already partially encoded parameters, so by removing normalize_parameters() instead, I was able to keep the rawurldecode() calls. See: #91 I have created a PR which merges your changes with AlexC's and removes normalize_parameters() in favor of encoding them in the join_with_equals_sign() function: #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.