Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice when pretty permalinks are not being used #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add notice when pretty permalinks are not being used #33

wants to merge 1 commit into from

Conversation

salcode
Copy link

@salcode salcode commented Dec 4, 2016

screenshot 2016-12-04 12 36 38

See #32

@joehoyle
Copy link
Member

joehoyle commented Dec 4, 2016

We should just fix working without permalinks

@salcode
Copy link
Author

salcode commented Dec 4, 2016

@joehoyle That is a great idea but I'd still like to see this warning put in place as a temporary fix (until it works without pretty permalinks)

@salcode
Copy link
Author

salcode commented Dec 7, 2016

Now that WP 4.7 is out with the REST API in it - congratulations! Along with this, I'm guessing this plugin will increase in popularity.

On Sunday I was at WCUS's contributor day. When I decided to contribute to core I started out with this plugin on a fresh install to test endpoints and I got this cryptic error. I then posted a message to slack and got no response. I finally asked one of the organizers regarding testing the endpoints about this error and the suggestion I got was to use a different tool to test the endpoints. This was a lousy user experience, which is bad for the REST API reputation and WordPress's reputation.

Adding this notice will prevent others from having a similar experience.

I won't badger any further regarding this PR but I wanted to share my motivation for it.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants