Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS Customizer doesn't play well with newer PHP #1771

Closed
benlk opened this issue Aug 9, 2019 · 0 comments
Closed

LESS Customizer doesn't play well with newer PHP #1771

benlk opened this issue Aug 9, 2019 · 0 comments
Assignees
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug type: tech debt For necessary updates because code is old

Comments

@benlk
Copy link
Collaborator

benlk commented Aug 9, 2019

As reported in HS#4080,

https://github.com/INN/largo/blob/c41d8519370b48a6e53ce36b3b516d3e54e39d66/inc/custom-less-variables.php#L773

Warning: preg_match_all(): Compilation failed: invalid range in character class at offset 44 in /wp-content/themes/largo/inc/custom-less-variables.php on line 776

Warning: Invalid argument supplied for foreach() in /wp-content/themes/largo/inc/custom-less-variables.php on line 778

This can be fixed with, as @joshdarby noted in that thread.

-               $pattern = '#/\*\*\s+(?<comment>.*)\s+\*/\s*@(?P<name>[\w-_]+):\s*(?P<value>[^;]*);#Us';
+               $pattern = '#/\*\*\s+(?<comment>.*)\s+\*/\s*@(?P<name>[\w\-_]+):\s*(?P<value>[^;]*);#Us';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: bug type: tech debt For necessary updates because code is old
Projects
None yet
Development

No branches or pull requests

2 participants