Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Largo to latest version #32

Open
5 tasks
benlk opened this issue Feb 13, 2020 · 2 comments
Open
5 tasks

Bump Largo to latest version #32

benlk opened this issue Feb 13, 2020 · 2 comments
Labels
blocked bug dependencies Pull requests that update a dependency file

Comments

@benlk
Copy link
Collaborator

benlk commented Feb 13, 2020

Note that there is no time set aside for this.

  • Largo to 0.6.4
  • Review for any conflicts with the existing child theme:
    • styles?
    • templates
    • functions
@benlk benlk added this to the MCIR-003 - Site Updates milestone Feb 13, 2020
@benlk benlk mentioned this issue Feb 17, 2020
3 tasks
@benlk
Copy link
Collaborator Author

benlk commented Feb 18, 2020

This site has Largo's LESS Customizer active.

Largo 0.6.4 didn't fix WPBuddy/largo#1771.

The patch for that is WPBuddy/largo#1772, which is merged in Largo 0.7, but Largo 0.7 is not yet released.

Because updating Largo triggers a recompile of the LESS Custom Vars, we should not update Largo until we can update this site to a version of Largo that will not have this problem.


Here's the current settings via a unserialized dump of the _transient_customlessvars_midwestcenter_current transient from the wp_options table:

["variables"]=>
  array(15) {
    ["baseColor"]=>
    string(7) "#4e7013"
    ["headerFooterColor"]=>
    string(7) "#222222"
    ["preFooterColor"]=>
    string(7) "#dddddd"
    ["linkColor"]=>
    string(7) "#2275bb"
    ["linkColorHover"]=>
    string(7) "#2275bb"
    ["postBoxBackgroundColor"]=>
    string(7) "#ffffff"
    ["bodyBackground"]=>
    string(7) "#ffffff"
    ["pageBackground"]=>
    string(7) "#ffffff"
    ["textColor"]=>
    string(7) "#333333"
    ["sansFontFamily"]=>
    string(46) ""Helvetica Neue", Helvetica, Arial, sans-serif"
    ["serifFontFamily"]=>
    string(40) "Georgia, "Times New Roman", Times, serif"
    ["baseFontFamily"]=>
    string(16) "@serifFontFamily"
    ["baseLineHeight"]=>
    string(3) "1.5"
    ["baseline"]=>
    string(4) "24px"
    ["baseFontSize"]=>
    string(4) "16px"
  }

@benlk
Copy link
Collaborator Author

benlk commented Feb 18, 2020

Removing the Largo update from #35 at this time.

The change made in 5156c9e was:

--- a/wp-content/themes/largo
+++ b/wp-content/themes/largo
@@ -1 +1 @@
-Subproject commit 14b794dae07daff28d6bb2a92a2fac5ecf983415
+Subproject commit c41d8519370b48a6e53ce36b3b516d3e54e39d66

@benlk benlk mentioned this issue Feb 18, 2020
1 task
@benlk benlk added blocked bug dependencies Pull requests that update a dependency file labels Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant