Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date and link to the search results partial #1177

Merged
merged 4 commits into from
Mar 22, 2016
Merged

Add date and link to the search results partial #1177

merged 4 commits into from
Mar 22, 2016

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Mar 18, 2016

Changes

  • Adds date above the excerpt, in a small.date element
  • Adds the permalink to the search results, below the excerpt
  • Styles the date grey

Using wenews:

screen shot 2016-03-18 at 6 16 31 pm

screen shot 2016-03-18 at 6 16 39 pm

## Why

RNS-198.

@benlk benlk added type: improvement priority: normal Must be completed before release of this version of plugin. status: needs review labels Mar 18, 2016
@benlk benlk added this to the 0.5.5 - Story Elements milestone Mar 18, 2016
@aschweigert
Copy link

I would prefer date and link both below the except, so:

Headline
Excerpt
Date | URL

@aschweigert
Copy link

also tighten up the space before/after the excerpt, just make that the same visual space as we have between the lines of text in the excerpt

@aschweigert aschweigert assigned benlk and unassigned aschweigert Mar 21, 2016
@benlk
Copy link
Collaborator Author

benlk commented Mar 22, 2016

Paragraph margin-bottom to 0, "Date | url" in play:

screen shot 2016-03-22 at 5 46 21 pm

screen shot 2016-03-22 at 5 46 34 pm

@benlk benlk assigned aschweigert and unassigned benlk Mar 22, 2016
@aschweigert
Copy link

headline is probably a touch big on larger screens, let's merge and see where we're at

aschweigert added a commit that referenced this pull request Mar 22, 2016
@aschweigert
Merge pull request #1177 from INN/1162-more-mods-RNS-198
e3f90eb 
Add date and link to the search results partial
@aschweigert aschweigert merged commit e3f90eb into develop Mar 22, 2016
@aschweigert aschweigert deleted the 1162-more-mods-RNS-198 branch March 22, 2016 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aschweigert aschweigert

Labels
priority: normal Must be completed before release of this version of plugin. type: improvement
Projects
None yet
Milestone
0.5.5 - Story Elements
Development

Successfully merging this pull request may close these issues.
2 participants
@benlk @aschweigert