Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .screen-reader-text CSS class, improve homepage CSS imports #1530

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Add .screen-reader-text CSS class, improve homepage CSS imports #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28efc0c
add .screen-reader-text CSS class using .visuallyhidden; update .visu…
benlk Sep 10, 2018
84ab669
Switch to LESS (reference) imports for mixins and variables on homepages
benlk Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions css/editor-style.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/editor-style.min.css
View file
Open in desktop

Large diffs are not rendered by default.

33 changes: 20 additions & 13 deletions css/style.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/style.min.css
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 2 additions & 39 deletions homepages/assets/css/single.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion homepages/assets/css/single.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

128 changes: 1 addition & 127 deletions homepages/assets/css/top-stories.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion homepages/assets/css/top-stories.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 6 additions & 8 deletions homepages/assets/less/single.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
@import "../../../less/inc/mixins.less";

@sky: #6cb9e1;
@fog: #ddd;
@grey: #666;
@import (reference) "../../../less/inc/mixins.less";
@import (reference) "../../../less/inc/variables.less";

#main,
.home-top {
Expand Down Expand Up @@ -54,7 +51,8 @@
font-weight: bold;
}
.view-list & {
color: @grey;
// change color of the control when the backgorund image is gone
color: @grayDark;
text-shadow: none;
a {
color: inherit;
Expand Down Expand Up @@ -100,7 +98,7 @@
font-size: 80%;
}
h5.byline {
color: @fog;
color: @grayLighter;
}
article {
border-top: solid 3px rgba(red(@sky), green(@sky), blue(@sky), 0.5);
Expand Down Expand Up @@ -170,7 +168,7 @@
.byline,
.byline a,
section {
color: @fog;
color: @grayLighter;
}
.byline {
font-weight: bold;
Expand Down
4 changes: 2 additions & 2 deletions homepages/assets/less/top-stories.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../../less/inc/variables.less";
@import "../../../less/inc/mixins.less";
@import (reference) "../../../less/inc/variables.less";
@import (reference) "../../../less/inc/mixins.less";

#homepage-featured {
margin-bottom: @baseline;
Expand Down
1 change: 1 addition & 0 deletions less/inc/footer.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ footer #boilerplate {
}
}

.screen-reader-text,
.back-to-top {
.visuallyhidden
}
16 changes: 11 additions & 5 deletions less/inc/mixins.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,18 @@
// CSS image replacement
// -------------------------
// Hide an item visually only
// https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/
.visuallyhidden {
position: absolute;
overflow: hidden;
border: 0;
clip: rect(0 0 0 0);
height: 1px; width: 1px;
margin: -1px; padding: 0; border: 0;
clip-path: inset(50%);
height: 1px;
margin: -1px;
overflow: hidden;
padding: 0;
position: absolute !important;
width: 1px;
word-wrap: normal !important;
}

// CSS image replacement
Expand Down Expand Up @@ -681,4 +687,4 @@
&:hover {
background-color: darken(@network, 5%);
}
}
}
4 changes: 3 additions & 1 deletion less/inc/variables.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
@white: #fff;



// Accent colors
// -------------------------
@sky: #6cb9e1;
@blue: #2275bb;
@blueDark: #0064cd;
@green: #46a546;
Expand Down Expand Up @@ -287,4 +289,4 @@
@tumblr: #35465c;
@pinterest: #cb2027;
@instagram: #125688;
@github: #4183c4;
@github: #4183c4;