Change source selector to a dropdown. #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks sooo nice!!! 👍 |
|
The nullpointer is because the test setup is looking for the buttons, which you've removed |
|
There are still buttons on the dialog pane. This one: https://travis-ci.org/WPIRoboticsProjects/GRIP/jobs/146452633#L2369 |
AustinShalit
force-pushed
the
sources-dropdown
branch
from
be44f10 to
2bc2bd6
Compare
Current coverage is 58.95% (diff: 83.33%)@@ master #631 diff @@
==========================================
Files 194 194
Lines 6051 6049 -2
Methods 0 0
Messages 0 0
Branches 550 550
==========================================
- Hits 3567 3566 -1
Misses 2323 2323
+ Partials 161 160 -1
|
AustinShalit
force-pushed
the
sources-dropdown
branch
from
2bc2bd6 to
0b67c42
Compare
|
I solved the test failure and also made a style change to remove the redundant word "add".
|
|
This G2G? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is make the sources box cleaner.
Anyone know why there is a null pointer error in the test?