Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues with generated C++ #798

Merged
merged 7 commits into from
Jan 30, 2017
Merged

Fix various issues with generated C++ #798

merged 7 commits into from
Jan 30, 2017

Conversation

SamCarlberg
Copy link
Member

@SamCarlberg SamCarlberg commented Jan 23, 2017 •
edited
Loading

Closes #797

@codecov-io
Copy link

codecov-io commented Jan 23, 2017 •
edited
Loading

Codecov Report

Merging #798 into master will increase coverage by -0.06%.

@@             Coverage Diff              @@
##             master     #798      +/-   ##
============================================
- Coverage     52.51%   52.45%   -0.06%     
- Complexity        0     1133    +1133     
============================================
  Files           240      240              
  Lines          7705     7708       +3     
  Branches        742      522     -220     
============================================
- Hits           4046     4043       -3     
- Misses         3475     3480       +5     
- Partials        184      185       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce1943...493b5af. Read the comment docs.

@SamCarlberg SamCarlberg added this to the v1.5.2 milestone Jan 23, 2017
@JLLeitschuh
Copy link
Member

Have you run the C++ code gen tests?

@SamCarlberg SamCarlberg mentioned this pull request Jan 27, 2017
Closed
@SamCarlberg
Copy link
Member Author

@JLLeitschuh C++ code gen tests are broken. But I've been generating code into an FRC project and compiling it there.

@SamCarlberg
Capitalize C++ getter methods
493b5af 
All public C++ functions should be PascalCase now
JLLeitschuh
JLLeitschuh approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get this shipped to the teams.

@SamCarlberg SamCarlberg merged commit 8d3fa6c into WPIRoboticsProjects:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

Assignees
No one assigned
Labels
location: codegen
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SamCarlberg @codecov-io @JLLeitschuh