Fixes #920 java codegen for filter lines #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original VM template was reassigning the filtered list to the outputs variable which would have no effect on the contents of the passed-in argument. Working pipelines in the GRIP GUI would show zero filtered lines when the generated class was used. Altered the template to manipulate the passed-in list object instead, using `clear()` and `addAll()`. Note: there doesn't appear to be unit tests for the generated classes, and I don't have time to write them. I tested the fix using test cases in our own FRC project that use the generated class.
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
- Coverage 54.5% 54.49% -0.02%
==========================================
Files 304 304
Lines 8318 8318
Branches 535 535
==========================================
- Hits 4534 4533 -1
- Misses 3587 3589 +2
+ Partials 197 196 -1 |
SamCarlberg
approved these changes
Feb 10, 2019
Member
|
Thanks for fixing this! |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original VM template was reassigning the filtered list to the outputs variable
which would have no effect on the contents of the passed-in argument. Working
pipelines in the GRIP GUI would show zero filtered lines when the generated class
was used.
Altered the template to manipulate the passed-in list object instead, using
clear()andaddAll().Note: there doesn't appear to be unit tests for the generated classes, and I
don't have time to write them. I tested the fix using test cases in our
own FRC project that use the generated class.