Cleanup javadoc, force UTF-8 encoding in Javadoc tasks #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `check` depend on javadoc task to enforce proper javadocs
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
============================================
+ Coverage 52.86% 52.89% +0.02%
Complexity 1 1
============================================
Files 327 327
Lines 8852 8852
Branches 560 560
============================================
+ Hits 4680 4682 +2
+ Misses 3969 3966 -3
- Partials 203 204 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
checkdepend onjavadoctask to enforce proper Javadocs. This means we won't get surprised by invalid Javadoc when merging PRs into master (and deleting all the published docs on the website in the process)